Page MenuHomeFreeBSD

Fix zfsd with the device_removal pool feature.
ClosedPublic

Authored by asomers on Sep 12 2023, 1:26 AM.
Tags
None
Referenced Files
F96588527: D41818.diff
Wed, Sep 25, 3:14 PM
Unknown Object (File)
Wed, Sep 18, 12:09 PM
Unknown Object (File)
Tue, Sep 17, 10:07 PM
Unknown Object (File)
Mon, Sep 16, 10:09 PM
Unknown Object (File)
Sun, Sep 15, 1:01 PM
Unknown Object (File)
Tue, Sep 10, 5:02 PM
Unknown Object (File)
Aug 23 2024, 9:23 AM
Unknown Object (File)
Aug 6 2024, 10:55 AM
Subscribers

Details

Summary

Previously zfsd would crash in the presence of a pool with a
top-level-vdev that had previously been removed. The crash only happens
in stable/14 and later, probably do to differences in libcxx, but the
change should be MFCed anyway.

PR: 273663
Reported by: Marek Zarychta <zarychtam@plan-b.pwste.edu.pl>
MFC after: 1 week
Sponsored by: Axcient

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 53536
Build 50427: arc lint + arc unit

Event Timeline

mav added inline comments.
cddl/usr.sbin/zfsd/vdev_iterator.cc
112

I personally would initialize vdevConfig above in declaration, but whatever.

This revision is now accepted and ready to land.Sep 12 2023, 1:39 PM