udl(4) patch for SIIG USB 2.0 DVI/VGA Pro support

[archimedes.gaviola_gmail.com]

Summary

This patch will enable the support of the SIIG USB 2.0 DVI/VGA Pro video device in udl(4) USB driver and its corresponding manpage. The chipset is based on DisplayLink DL-195. Please see details here including testing that works in 14.0-ALPHA4 and 15.0-CURRENT.

[archimedes.gaviola_gmail.com]

This patch will add the support of the SIIG USB 2.0 DVI/VGA Pro video device in the udl(4) USB driver and its corresponding manpage. The chipset is based on DisplayLink DL-195. Please see details here https://lists.freebsd.org/archives/freebsd-usb/2023-September/001174.html. This patch has been tested in 14.0-ALPHA4 and 15.0-CURRENT.

[archimedes.gaviola_gmail.com]

For review.

[lwhsu]

/usr/src/share/man/man4/udl.4

29

is this needed by DL-195, or generally udl needs it?

[emaste]

The next time you have a patch to upload to Phabricator please generate with full context -- see detailed instructions at https://wiki.freebsd.org/Phabricator

Based on this review the DL-195 is backwards compatible with the earlier ones I assume, although it looks like the mfgr groups the DL1x5 together (DL-115, DL-125, DL-165, DL-195). I see DL165 in udl.c though, so I guess the man page is just not updated.

I'm happy to shepherd this change in (if lwhsu doesn't) but may be a week or two.

[emaste]

Archimedes, can you confirm that desired Git author info is Archimedes Gaviola <[e-mail]>

/usr/src/share/man/man4/udl.4

29

Looks like always needed, just not documented before.

sys/dev/usb/video/udl.c:#include <dev/videomode/videomode.h>
sys/dev/usb/video/udl.c:#include <dev/videomode/edidvar.h>
sys/dev/usb/video/udl.c:MODULE_DEPEND(udl, videomode, 1, 1, 1);

29

(and we should fix that part first in a separate commit)

[archimedes.gaviola_gmail.com]

In D41798#952708, @emaste wrote:

The next time you have a patch to upload to Phabricator please generate with full context -- see detailed instructions at https://wiki.freebsd.org/Phabricator

@emaste this is noted, I will read the guidelines here https://wiki.freebsd.org/Phabricator for guidance.

Based on this review the DL-195 is backwards compatible with the earlier ones I assume, although it looks like the mfgr groups the DL1x5 together (DL-115, DL-125, DL-165, DL-195). I see DL165 in udl.c though, so I guess the man page is just not updated.

I'm happy to shepherd this change in (if lwhsu doesn't) but may be a week or two.

Thank you so much @emaste, yes the man page seems not updated.

/usr/src/share/man/man4/udl.4

29

No, it's not DL-195, it's generally the udl driver that needs it. I found this thread https://marc.info/?l=freebsd-current&m=142439494814118&w=2 that someone also did the same in compiling the kernel, because without it, it will fail.

[archimedes.gaviola_gmail.com]

In D41798#952740, @emaste wrote:

Archimedes, can you confirm that desired Git author info is Archimedes Gaviola <[e-mail]>

Yes, confirmed.

[emaste]

"videomode" correction pushed as 9888a79adad2