Page MenuHomeFreeBSD

gve: Make LRO work for jumbo packets
ClosedPublic

Authored by shailend_google.com on Sep 6 2023, 1:13 AM.
Tags
None
Referenced Files
F102786480: D41754.diff
Sun, Nov 17, 4:35 AM
Unknown Object (File)
Oct 13 2024, 11:51 AM
Unknown Object (File)
Oct 13 2024, 11:50 AM
Unknown Object (File)
Oct 13 2024, 11:50 AM
Unknown Object (File)
Oct 13 2024, 11:50 AM
Unknown Object (File)
Oct 13 2024, 11:48 AM
Unknown Object (File)
Sep 12 2024, 1:18 AM
Unknown Object (File)
Sep 11 2024, 4:33 PM
Subscribers

Details

Summary

Each Rx descriptor points to a packet buffer of size 2K, which means
that MTUs greater than 2K see multi-descriptor packets. The TCP-hood of
such packets was being incorrectly determined by looking for a flag on
the last descriptor instead of the first descriptor.

Also fixed and preogressed the version number.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

The main diff looks ok to me, I just don't understand the alignment change.

sys/dev/gve/gve.h
169

What's the purpose of increasing the alignment here? There's no mention of this in the review description.

If you want specific alignment within struct gve_rx_ring, wouldn't it be better to specify the alignment there?

This revision is now accepted and ready to land.Sep 6 2023, 1:44 PM
This revision now requires review to proceed.Sep 6 2023, 6:37 PM
shailend_google.com added inline comments.
sys/dev/gve/gve.h
169

Thanks, removed the unnecessary alignment.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 7 2023, 1:39 PM
This revision was automatically updated to reflect the committed changes.