Page MenuHomeFreeBSD

init_main: Switch from SLIST to STAILQ, fix order
ClosedPublic

Authored by cperciva on Sep 5 2023, 11:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 4, 6:29 AM
Unknown Object (File)
Sun, Feb 2, 12:30 PM
Unknown Object (File)
Mon, Jan 27, 2:38 PM
Unknown Object (File)
Sun, Jan 26, 11:52 PM
Unknown Object (File)
Sat, Jan 25, 12:09 PM
Unknown Object (File)
Thu, Jan 23, 6:37 PM
Unknown Object (File)
Jan 10 2025, 3:36 AM
Unknown Object (File)
Jan 10 2025, 1:39 AM
Subscribers

Details

Summary

Constructing an SLIST of SYSINITs by inserting them one by one at the
head of the list resulted in them being sorted in anti-stable order:
When two SYSINITs tied for (subsystem, order), they were executed in
the reverse order to the order in which they appeared in the linker
set.

Fixes: 9a7add6d01f3 "init_main: Switch from sysinit array to SLIST"

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Thank you; this fixes the weird performance problem that we've yet to fully root cause.

This revision is now accepted and ready to land.Sep 6 2023, 4:46 AM