Page MenuHomeFreeBSD

init_main: Switch from SLIST to STAILQ, fix order
ClosedPublic

Authored by cperciva on Sep 5 2023, 11:48 PM.
Tags
None
Referenced Files
F107101698: D41748.id126984.diff
Fri, Jan 10, 3:36 AM
F107096659: D41748.diff
Fri, Jan 10, 1:39 AM
Unknown Object (File)
Nov 20 2024, 11:49 PM
Unknown Object (File)
Nov 20 2024, 7:42 AM
Unknown Object (File)
Nov 18 2024, 2:05 PM
Unknown Object (File)
Nov 14 2024, 1:20 AM
Unknown Object (File)
Nov 13 2024, 11:17 PM
Unknown Object (File)
Nov 12 2024, 11:26 PM
Subscribers

Details

Summary

Constructing an SLIST of SYSINITs by inserting them one by one at the
head of the list resulted in them being sorted in anti-stable order:
When two SYSINITs tied for (subsystem, order), they were executed in
the reverse order to the order in which they appeared in the linker
set.

Fixes: 9a7add6d01f3 "init_main: Switch from sysinit array to SLIST"

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Thank you; this fixes the weird performance problem that we've yet to fully root cause.

This revision is now accepted and ready to land.Sep 6 2023, 4:46 AM