Page MenuHomeFreeBSD

init_main: Switch from SLIST to STAILQ, fix order
ClosedPublic

Authored by cperciva on Sep 5 2023, 11:48 PM.
Tags
None
Referenced Files
F102552464: D41748.diff
Wed, Nov 13, 11:17 PM
Unknown Object (File)
Tue, Nov 12, 11:26 PM
Unknown Object (File)
Oct 7 2024, 4:18 AM
Unknown Object (File)
Oct 7 2024, 4:17 AM
Unknown Object (File)
Oct 7 2024, 4:17 AM
Unknown Object (File)
Oct 7 2024, 3:54 AM
Unknown Object (File)
Sep 26 2024, 8:31 PM
Unknown Object (File)
Sep 26 2024, 3:58 PM
Subscribers

Details

Summary

Constructing an SLIST of SYSINITs by inserting them one by one at the
head of the list resulted in them being sorted in anti-stable order:
When two SYSINITs tied for (subsystem, order), they were executed in
the reverse order to the order in which they appeared in the linker
set.

Fixes: 9a7add6d01f3 "init_main: Switch from sysinit array to SLIST"

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Thank you; this fixes the weird performance problem that we've yet to fully root cause.

This revision is now accepted and ready to land.Sep 6 2023, 4:46 AM