Details
- Reviewers
imp emaste - Group Reviewers
tests - Commits
- rG4ec9ee991276: libc: Add a wide version of snprintf_test.
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 53431 Build 50322: arc lint + arc unit
Event Timeline
| lib/libc/tests/stdio/snprintf_test.c | ||
|---|---|---|
| 19–26 | This (block) change is not necessarily required, but for diff reduction between the two versions? | |
Awesome new tests!
| lib/libc/tests/stdio/snprintf_test.c | ||
|---|---|---|
| 15–17 | Is there a reason why this needs to be defined here (it's available in sys/param.h)? | |
| 24 | Just in case someone adds a no-argument test. | |
| lib/libc/tests/stdio/swprintf_test.c | ||
| 16–19 | Same comment as the previous one. | |
| 133 |
This helps ensure that the preconditions for the test are being handled/checked properly and that if the locale does not exist, the test program doesn't crash on collection (that's what would happen if the assertion was placed in ATF_TP_ADD_TCS). | |
| 139 | Whitespace. | |
| lib/libc/tests/stdio/snprintf_test.c | ||
|---|---|---|
| 15–17 | I didn't want to pull it in just for that one trivial macro. | |
| 19–26 | correct | |
| lib/libc/tests/stdio/swprintf_test.c | ||
| 133 | There are precisely zero mentions of setup fixtures in the ATF documentation and zero occurrences of the word “setup” in the ATF C API headers. | |
| 139 | matter of taste | |