The :R:S expressions removed the .pl extension only to add it back
again, so just trim them to using :T alone.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I'd consider defining a variable instead of repeating ${.ALLSRC:T}, or even keep the full message in a variable, so that future changes are easier.
so just trim them to using :T alone.
Extra "to"?
Comment Actions
Well, some cases use ${.IMPSRC:T} and others use ${.ALLSRC:T}. It may make sense to define a variable for the rest of the message, in particular to simplify Ed's request to use @generated in the comment.
so just trim them to using :T alone.
Extra "to"?
Hmm, I don't think so, but it is a bit wordy. "... again, just use :T alone." might be clearer.
Comment Actions
To me this looks tidier and also more sensible than before; indeed, why did it set the suffix to .pl only to remove it and add it again?