Page MenuHomeFreeBSD

Makefile.asm: Simplify variable expansions in generated headers
ClosedPublic

Authored by jhb on Aug 24 2023, 7:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 16, 3:11 PM
Unknown Object (File)
Mon, Oct 14, 6:30 PM
Unknown Object (File)
Sun, Oct 13, 11:43 PM
Unknown Object (File)
Sun, Oct 13, 4:19 AM
Unknown Object (File)
Fri, Oct 11, 10:14 PM
Unknown Object (File)
Thu, Oct 10, 3:01 PM
Unknown Object (File)
Wed, Oct 9, 4:38 AM
Unknown Object (File)
Oct 8 2024, 12:33 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I'd consider defining a variable instead of repeating ${.ALLSRC:T}, or even keep the full message in a variable, so that future changes are easier.

so just trim them to using :T alone.

Extra "to"?

This revision is now accepted and ready to land.Aug 28 2023, 4:26 PM
emaste added a subscriber: jkim.

I'd consider defining a variable instead of repeating ${.ALLSRC:T}, or even keep the full message in a variable, so that future changes are easier.

Well, some cases use ${.IMPSRC:T} and others use ${.ALLSRC:T}. It may make sense to define a variable for the rest of the message, in particular to simplify Ed's request to use @generated in the comment.

so just trim them to using :T alone.

Extra "to"?

Hmm, I don't think so, but it is a bit wordy. "... again, just use :T alone." might be clearer.

To me this looks tidier and also more sensible than before; indeed, why did it set the suffix to .pl only to remove it and add it again?