Page MenuHomeFreeBSD
Differential D41536

libcrypto: Don't embed $FreeBSD$ in generated assembly files
ClosedPublic
Actions

Authored by jhb on Aug 21 2023, 10:06 PM.
Tags
None
Referenced Files
F113833801: D41536.id126338.diff
Fri, Apr 4, 7:40 AM
Unknown Object (File)
Feb 8 2025, 2:50 AM
Unknown Object (File)
Jan 17 2025, 12:13 PM
Unknown Object (File)
Dec 24 2024, 4:01 AM
Unknown Object (File)
Dec 19 2024, 3:39 PM
Unknown Object (File)
Dec 17 2024, 9:55 AM
Unknown Object (File)
Dec 2 2024, 4:33 PM
Unknown Object (File)
Nov 29 2024, 3:36 AM
View All 74 Files
Subscribers
imp

Details

Reviewers
khorben_defora.org
emaste
gallatin
ngie
Commits
rG8f54a610e00d: libcrypto: Don't embed $FreeBSD$ in generated assembly files
rG7a56f5af7185: libcrypto: Don't embed $FreeBSD$ in generated assembly files

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Aug 21 2023, 10:06 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 21 2023, 10:06 PM
jhb requested review of this revision.Aug 21 2023, 10:06 PM
Harbormaster completed remote builds in B53218: Diff 126338.Aug 21 2023, 10:06 PM
jhb added a child revision: D41537: libcrypto: Add new assembly files added in OpenSSL 3.0..Aug 21 2023, 10:06 PM
emaste accepted this revision.Aug 21 2023, 10:52 PM
emaste added inline comments.
secure/lib/libcrypto/Makefile.asm
54

We might want to do the @generated while we're at it

This revision is now accepted and ready to land.Aug 21 2023, 10:52 PM
emaste added a reviewer: ngie.Aug 21 2023, 10:52 PM
gallatin accepted this revision.Aug 21 2023, 11:20 PM
ngie accepted this revision.Aug 22 2023, 12:17 AM
jhb added inline comments.Aug 22 2023, 3:23 AM
secure/lib/libcrypto/Makefile.asm
54

Hmm, perhaps as a separate followup as that will require regenerating all the files.

emaste added a comment.Aug 22 2023, 3:53 AM

Hmm, perhaps as a separate followup as that will require regenerating all the files.

Sounds good, a separate commit if at all

Closed by commit rG7a56f5af7185: libcrypto: Don't embed $FreeBSD$ in generated assembly files (authored by jhb). · Explain WhyAug 22 2023, 4:05 AM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG7a56f5af7185: libcrypto: Don't embed $FreeBSD$ in generated assembly files.
imp added a commit: rG8f54a610e00d: libcrypto: Don't embed $FreeBSD$ in generated assembly files.Aug 23 2023, 5:59 PM

Revision Contents
Changeset List

PathSize
secure/
lib/
libcrypto/
57 lines

Diff 126361

View Options

secure/lib/libcrypto/Makefile.asm

Loading...