Page MenuHomeFreeBSD
Differential D41522

libc: Document support for binary integers.
ClosedPublic
Actions

Authored by des on Aug 21 2023, 12:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 28, 3:22 PM
Unknown Object (File)
Sat, Sep 28, 5:04 AM
Unknown Object (File)
Fri, Sep 27, 4:14 PM
Unknown Object (File)
Fri, Sep 27, 6:43 AM
Unknown Object (File)
Sun, Sep 22, 1:06 AM
Unknown Object (File)
Sat, Sep 21, 4:42 PM
Unknown Object (File)
Fri, Sep 20, 8:56 PM
Unknown Object (File)
Thu, Sep 19, 9:14 AM
View All 61 Files
Subscribers
debdrup
emaste
imp

Details

Reviewers
debdrup
emaste
Commits
rG76edfabbecde: libc: Document support for binary integers.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 53202
Build 50093: arc lint + arc unit

Event Timeline

des created this revision.Aug 21 2023, 12:57 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 21 2023, 12:57 PM
des requested review of this revision.Aug 21 2023, 12:57 PM
Harbormaster completed remote builds in B53202: Diff 126296.Aug 21 2023, 12:58 PM
des added a parent revision: D41511: libc: Implement N2630..Aug 21 2023, 12:58 PM
des updated this revision to Diff 126297.Aug 21 2023, 1:01 PM

dioux -> bdioux

Harbormaster completed remote builds in B53203: Diff 126297.Aug 21 2023, 1:01 PM
debdrup accepted this revision.Aug 21 2023, 1:03 PM
debdrup added a subscriber: debdrup.

Only spotted two minor nits, but they can be fixed before pushing as they don't have to hold up things.

lib/libc/stdio/printf.3
421–422

Why the newline here?

lib/libc/stdio/scanf.3
288–289

Similar to the other, why a newline here?

This revision is now accepted and ready to land.Aug 21 2023, 1:03 PM
des marked 2 inline comments as done.Aug 21 2023, 1:07 PM
des added inline comments.
lib/libc/stdio/printf.3
421–422

it makes no difference for the output but makes the source more readable as each element in the enumeration has the same form.

lib/libc/stdio/scanf.3
288–289

same reason

des marked 2 inline comments as done.Aug 21 2023, 1:07 PM
emaste accepted this revision.Aug 21 2023, 5:32 PM
emaste added a subscriber: emaste.
emaste added inline comments.
lib/libc/stdio/printf.3
421–422

igor complains about blank lines though

des added inline comments.Aug 25 2023, 11:50 PM
lib/libc/stdio/printf.3
421–422

where?

Closed by commit rG76edfabbecde: libc: Document support for binary integers. (authored by des). · Explain WhyAug 28 2023, 3:38 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG76edfabbecde: libc: Document support for binary integers..
des mentioned this in rGbae932999e0f: libc: Implement N2630..Sep 7 2023, 8:29 PM

Revision Contents
Changeset List

PathSize
lib/
libc/
stdio/
34 lines
13 lines
stdlib/
4 lines
4 lines

Diff 126296

View Options

lib/libc/stdio/printf.3

Loading...
View Options

lib/libc/stdio/scanf.3

Loading...
View Options

lib/libc/stdlib/strtol.3

Loading...
View Options

lib/libc/stdlib/strtoul.3

Loading...