Page MenuHomeFreeBSD

dtc: Sync with upstream commit 26a0fe5
ClosedPublic

Authored by jlduran on Aug 16 2023, 3:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 22, 5:34 AM
Unknown Object (File)
Sep 24 2024, 2:20 AM
Unknown Object (File)
Sep 23 2024, 4:29 PM
Unknown Object (File)
Sep 18 2024, 1:20 PM
Unknown Object (File)
Sep 18 2024, 4:28 AM
Unknown Object (File)
Sep 17 2024, 6:08 PM
Unknown Object (File)
Sep 17 2024, 7:47 AM
Unknown Object (File)
Sep 16 2024, 7:24 PM

Details

Summary
  • 0206c0f ("Handle top-level /delete-node/ directives.")
  • d612a9e ("Remove C++11 standard constrain")
  • Remove extra white lines after the $FreeBSD$ tag removal

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • Rebase (remove FreeBSD RCSIDs).
This revision is now accepted and ready to land.Aug 17 2023, 2:19 AM
jlduran edited the summary of this revision. (Show Details)
  • Remove extra white lines after the $FreeBSD$ tag removal
This revision now requires review to proceed.Aug 17 2023, 2:29 AM
This revision is now accepted and ready to land.Aug 17 2023, 8:21 AM
This revision was automatically updated to reflect the committed changes.

I noticed this change broke macOS cross-builds on GitHub. I guess due to the fact that man clang on macOS says: The default C++ language standard is gnu++98.

Specifying a C standard in the Makefile (CXXSTD= c++14) could do the trick, but I would prefer to set it globally or on the GitHub runner itself. Suggestions?

In D41482#957685, @jlduran_gmail.com wrote:

I would prefer to set it globally or on the GitHub runner itself. Suggestions?

If the default C++ standard in base system Clang / Clang 15/16 doesn't match what's in macOS Clang then I suspect we should set it in the cross-build script or actions config.