iscsictl: Return non-zero status on write failure.
ClosedPublic
Actions

Authored by yanhaowang on Aug 11 2023, 6:38 AM.

Details

Reviewers

lwhsu
des

Commits

rG00f003da7d07: iscsictl(8): Complete libxo transition

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 53047
Build 49938: arc lint + arc unit

Event Timeline

yanhaowang created this revision.Aug 11 2023, 6:38 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 11 2023, 6:38 AM

yanhaowang requested review of this revision.Aug 11 2023, 6:38 AM

Harbormaster completed remote builds in B53047: Diff 125860.Aug 11 2023, 6:38 AM

yanhaowang added reviewers: lwhsu, des.Aug 11 2023, 6:38 AM

des requested changes to this revision.Aug 17 2023, 3:27 PM

des added inline comments.

usr.bin/iscsictl/iscsictl.c
714	These `fprintf()` calls should be replaced with `xo_error()`.

This revision now requires changes to proceed.Aug 17 2023, 3:27 PM

Using xo_error instead of 'fprintf'.
Decide use number style here.

Harbormaster completed remote builds in B53186: Diff 126256.Aug 20 2023, 7:05 AM

des accepted this revision.Aug 27 2023, 12:00 AM

des added inline comments.

usr.bin/iscsictl/iscsictl.c
1059	Everything from here on down could be written as `exit(!!failed);`, but it's also fine as-is.

This revision is now accepted and ready to land.Aug 27 2023, 12:00 AM

Closed by commit rG00f003da7d07: iscsictl(8): Complete libxo transition (authored by yanhaowang, committed by lwhsu). · Explain WhyOct 12 2024, 6:30 PM

This revision was automatically updated to reflect the committed changes.

lwhsu added a commit: rG00f003da7d07: iscsictl(8): Complete libxo transition.

Revision Contents
Changeset List

Path

Size

usr.bin/

iscsictl/

iscsictl.c

13 lines

Diff 125860

View Options

usr.bin/iscsictl/iscsictl.c

iscsictl: Return non-zero status on write failure.ClosedPublicActions