Differential D41350

Retire non-EARLY_AP_STARTUP code
Needs RevisionPublic
Actions

Authored by emaste on Aug 7 2023, 8:54 PM.

Details

Reviewers

jrtc27

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste created this revision.Aug 7 2023, 8:54 PM

Herald added subscribers: riscv, glebius, ehem_freebsd_m5p.com and 2 others. · View Herald TranscriptAug 7 2023, 8:54 PM

emaste requested review of this revision.Aug 7 2023, 8:54 PM

Uh, not all architectures currently support EARLY_AP_STARTUP. Even arm64 doesn't; there's a comment in the GICv3 driver for example about it IIRC.

This revision now requires changes to proceed.Aug 7 2023, 8:56 PM

The basic problem on arm64 is:

IPIs need an INTRNG PIC
INTRNG PIC needs newbus to probe up to at least BUS_PASS_INTERRUPT
newbus doesn't run until SI_SUB_DRIVERS
SI_SUB_SMP comes before SI_SUB_DRIVERS under EARLY_AP_STARTUP

Uh, not all architectures currently support EARLY_AP_STARTUP

Yeah, I noticed this when only x86 config files needed modification. See D41351 for a proposed first step.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

conf/

FIRECRACKER

1 line

GENERIC

1 line

MINIMAL

1 line

cddl/

dev/

dtrace/

amd64/

dtrace_subr.c

28 lines

dtrace_load.c

29 lines

i386/

dtrace_subr.c

28 lines

powerpc/

dtrace_subr.c

5 lines

conf/

NOTES

6 lines

options

1 line

dev/

acpica/

acpi.c

16 lines

acpi_cpu.c

5 lines

hwpmc/

hwpmc_mod.c

4 lines

hyperv/

vmbus/

vmbus.c

28 lines

kvm_clock/

kvm_clock.c

34 lines

ntb/

ntb_hw/

ntb_hw_intel.c

19 lines

usb/

usb_process.c

9 lines

xen/

control/

control.c

31 lines

geom/

eli/

g_eli.c

8 lines

i386/

conf/

GENERIC

1 line

MINIMAL

1 line

kern/

20 lines

15 lines

17 lines

47 lines

net/

netisr.c

27 lines

riscv/

clock.c

4 lines

mp_machdep.c

5 lines

sys/

kernel.h

5 lines

x86/

isa/

clock.c

8 lines

x86/

65 lines

14 lines

4 lines

5 lines

Diff 125670

View Options

sys/amd64/conf/FIRECRACKER

View Options

sys/amd64/conf/GENERIC

View Options

sys/amd64/conf/MINIMAL

View Options

sys/cddl/dev/dtrace/amd64/dtrace_subr.c

View Options

sys/cddl/dev/dtrace/dtrace_load.c

View Options

sys/cddl/dev/dtrace/i386/dtrace_subr.c

View Options

sys/cddl/dev/dtrace/powerpc/dtrace_subr.c

View Options

sys/conf/NOTES

View Options

sys/conf/options

View Options

sys/dev/acpica/acpi.c

View Options

sys/dev/acpica/acpi_cpu.c

View Options

sys/dev/hwpmc/hwpmc_mod.c

View Options

sys/dev/hyperv/vmbus/vmbus.c

View Options

sys/dev/kvm_clock/kvm_clock.c

View Options

sys/dev/ntb/ntb_hw/ntb_hw_intel.c

View Options

sys/dev/usb/usb_process.c

View Options

sys/dev/xen/control/control.c

View Options

sys/geom/eli/g_eli.c

View Options

sys/i386/conf/GENERIC

View Options

sys/i386/conf/MINIMAL

View Options

sys/kern/kern_clocksource.c

View Options

sys/kern/kern_cpu.c

View Options

sys/kern/subr_epoch.c

View Options

sys/kern/subr_intr.c

View Options

sys/net/netisr.c

View Options

sys/riscv/riscv/clock.c

View Options

sys/riscv/riscv/mp_machdep.c

View Options

sys/sys/kernel.h

View Options

sys/x86/isa/clock.c

View Options

sys/x86/x86/intr_machdep.c

View Options

sys/x86/x86/local_apic.c

View Options

sys/x86/x86/mca.c

View Options

Retire non-EARLY_AP_STARTUP codeNeeds RevisionPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 125670

sys/amd64/conf/FIRECRACKER

sys/amd64/conf/GENERIC

sys/amd64/conf/MINIMAL

sys/cddl/dev/dtrace/amd64/dtrace_subr.c

sys/cddl/dev/dtrace/dtrace_load.c

sys/cddl/dev/dtrace/i386/dtrace_subr.c

sys/cddl/dev/dtrace/powerpc/dtrace_subr.c

sys/conf/NOTES

sys/conf/options

sys/dev/acpica/acpi.c

sys/dev/acpica/acpi_cpu.c

sys/dev/hwpmc/hwpmc_mod.c

sys/dev/hyperv/vmbus/vmbus.c

sys/dev/kvm_clock/kvm_clock.c

sys/dev/ntb/ntb_hw/ntb_hw_intel.c

sys/dev/usb/usb_process.c

sys/dev/xen/control/control.c

sys/geom/eli/g_eli.c

sys/i386/conf/GENERIC

sys/i386/conf/MINIMAL

sys/kern/kern_clocksource.c

sys/kern/kern_cpu.c

sys/kern/subr_epoch.c

sys/kern/subr_intr.c

sys/net/netisr.c

sys/riscv/riscv/clock.c

sys/riscv/riscv/mp_machdep.c

sys/sys/kernel.h

sys/x86/isa/clock.c

sys/x86/x86/intr_machdep.c

sys/x86/x86/local_apic.c

sys/x86/x86/mca.c

sys/x86/x86/mp_x86.c

Retire non-EARLY_AP_STARTUP code
Needs RevisionPublic
Actions

Revision Contents
Changeset List