x86: make EARLY_AP_STARTUP mandatory
ClosedPublic
Actions

Authored by emaste on Aug 7 2023, 9:03 PM.

Details

Reviewers

jhb
wollman
markj

Commits

rGc2009f3b5bd6: x86: make EARLY_AP_STARTUP mandatory
rG792655abd64c: x86: make EARLY_AP_STARTUP mandatory

Summary

When early AP startup was introduced in 2016 it was put behind a kernel
option EARLY_AP_STARTUP as a transition aid, so that it could be turned
off if necessary.  For x86 the non-EARLY_AP_STARTUP case is no longer
functional, so disallow it.

Other archs are still incompatible with EARLY_AP_STARTUP, so the option
cannot yet be removed entirely.

Reported by:    wollman
Sponsored by:   The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Aug 7 2023, 9:03 PM

emaste created this revision.

see fdce57a04219d7a36c6646950fde6c8bcd97c044 for original commit that introduced the option

rG:fdce57a04219d7a36c6646950fde6c8bcd97c044

emaste mentioned this in D41350: Retire non-EARLY_AP_STARTUP code.Aug 7 2023, 9:13 PM

Move it from MINIMAL and GENERIC to DEFAULTS?

Still needs a mention in UPDATING.

Move it from MINIMAL and GENERIC to DEFAULTS?

D41352

Still needs a mention in UPDATING.

Indeed, although really it was needed months or years ago. @imp any suggestions on how to handle this case? Do we just add a note with today's date that mentions this was needed some time ago?

emaste mentioned this in D41352: x86: move EARLY_AP_STARTUP into defaults.Aug 8 2023, 1:38 PM

emaste mentioned this in rGda695970cee9: UPDATING: add a note about EARLY_AP_STARTUP on x86.Sep 27 2023, 4:36 PM

emaste added a reviewer: wollman.Sep 27 2023, 4:37 PM

emaste added a reviewer: markj.Sep 27 2023, 4:42 PM

You could also remove some hideous ifdefs from dtrace_gethrtime_init_early() for i386 and amd64. I'm happy to do that separately though.

This revision is now accepted and ready to land.Sep 27 2023, 5:15 PM

Closed by commit rG792655abd64c: x86: make EARLY_AP_STARTUP mandatory (authored by emaste). · Explain WhyOct 9 2023, 8:12 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG792655abd64c: x86: make EARLY_AP_STARTUP mandatory.

emaste added a commit: rGc2009f3b5bd6: x86: make EARLY_AP_STARTUP mandatory.Oct 13 2023, 3:44 PM