Differential D41324

iflib: Fix white space and reduce some line lengths
ClosedPublic
Actions

Authored by erj on Aug 4 2023, 6:03 PM.

Tags

None

Referenced Files

	F98044091: D41324.id.diff
	Wed, Oct 2, 3:59 AM

	Unknown Object (File)
	Tue, Oct 1, 1:18 AM

	Unknown Object (File)
	Sun, Sep 29, 2:06 PM

	Unknown Object (File)
	Sat, Sep 28, 1:44 AM

	Unknown Object (File)
	Wed, Sep 25, 4:37 PM

	Unknown Object (File)
	Wed, Sep 25, 5:32 AM

	Unknown Object (File)
	Tue, Sep 24, 7:37 AM

	Unknown Object (File)
	Sun, Sep 22, 12:09 PM

View All 44 Files

Subscribers

Details

Reviewers

shurd
kbowling

Group Reviewers

Commits

rGdadd804ded83: iflib: Fix white space and reduce some line lengths
rG7f527d48124b: iflib: Fix white space and reduce some line lengths

Summary

Signed-off-by: Eric Joyner <erj@FreeBSD.org>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

erj created this revision.Aug 4 2023, 6:03 PM

Herald added a reviewer: shurd. · View Herald TranscriptAug 4 2023, 6:03 PM

Herald added a reviewer: iflib. · View Herald Transcript

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald Transcript

erj requested review of this revision.Aug 4 2023, 6:03 PM

Harbormaster completed remote builds in B52980: Diff 125595.Aug 4 2023, 6:03 PM

erj added a child revision: D41325: iflib: Remove redundant variable.Aug 4 2023, 6:05 PM

erj mentioned this in D39930: iflib: Add subinterface interrupt allocation function.Aug 4 2023, 6:17 PM

kbowling accepted this revision.Aug 4 2023, 6:47 PM

This revision is now accepted and ready to land.Aug 4 2023, 6:47 PM

This change doesn't acutally fix white space violations but introduces additional ones as according to style(9): 'Second level indents are four spaces'.

In D41324#941005, @marius wrote:

This change doesn't acutally fix white space violations but introduces additional ones as according to style(9): 'Second level indents are four spaces'.

It's "fix" in the context of whatever style the existing iflib code uses; if you want style(9) adherence, someone should probably re-write the iflib code to match it.

Closed by commit rG7f527d48124b: iflib: Fix white space and reduce some line lengths (authored by erj). · Explain WhyAug 7 2023, 10:47 PM

This revision was automatically updated to reflect the committed changes.

erj added a commit: rG7f527d48124b: iflib: Fix white space and reduce some line lengths.

erj added a commit: rGdadd804ded83: iflib: Fix white space and reduce some line lengths.Aug 24 2023, 9:16 PM

Revision Contents
Changeset List

Path

Size

sys/

net/

7 lines

18 lines

Diff 125683

sys/net/iflib.h

Loading...

sys/net/iflib.c

Loading...