Page MenuHomeFreeBSD
Differential D41299

pam_krb5: Clarify a loop condition.
ClosedPublic
Actions

Authored by des on Aug 3 2023, 3:45 PM.
Tags
None
Referenced Files
F98344592: D41299.diff
Thu, Oct 3, 2:39 AM
Unknown Object (File)
Tue, Oct 1, 2:13 AM
Unknown Object (File)
Thu, Sep 19, 10:17 AM
Unknown Object (File)
Thu, Sep 19, 5:27 AM
Unknown Object (File)
Wed, Sep 18, 1:02 PM
Unknown Object (File)
Wed, Sep 18, 7:10 AM
Unknown Object (File)
Tue, Sep 17, 2:51 PM
Unknown Object (File)
Tue, Sep 17, 1:54 PM
View All 60 Files
Subscribers
cy
imp

Details

Reviewers
cy
Commits
rG27968aa02206: pam_krb5: Clarify a loop condition.
rGacc7cf8641dc: pam_krb5: Clarify a loop condition.
Summary

The closing parenthesis was in the wrong location, so instead of assigning the return value to krbret and then comparing it to zero, we were assigning the result of the comparison to krbret and then comparing that to zero. This has no practical significance since the value is not used after the loop terminates.

PR: 229719

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 52958
Build 49849: arc lint + arc unit

Revision Contents
Changeset List

PathSize
lib/
libpam/
modules/
pam_krb5/
3 lines

Diff 125512

View Options

lib/libpam/modules/pam_krb5/pam_krb5.c

Loading...