bsdinstall: revisit the finalconfig step

[khorben_defora.org]

Summary

This commit contains the following changes:

• moves the "finalconfig" step into a dedicated script
• adds a "Finish" button to replace the first choice (exit and apply)
• uses a loop instead of recursing into itself

Sponsored by: The FreeBSD Foundation

I would also like to mention that if this step is not skipped (e.g., with $BSDINSTALL_SKIP_FINALCONFIG), some other steps can be skipped by default (like "adduser", "hardening", "services", and perhaps "time") since this menu gives a chance to perform them.

This is also relevant to D40142.

I also wish the manual configuration step could be merged into this (i.e., chrooting a shell into the newly installed system), but this conflicts with the current design of bsdinstall, which relies on a set of temporary configuration files before creating the final ones.

Test Plan

I have created a stand-alone copy of usr.sbin/bsdinstall, slightly modified in order to allow local testing without requiring a new installation image for every change.

$ git clone --branch khorben/finalconfig \
      https://github.com/khorben/bsdinstall.git
$ cd bsdinstall
$ less README.md
[...]
$ cat > test.sh << EOF
#!/bin/sh

BSDINSTALLDIR="\$PWD"
DESTDIR="\$BSDINSTALLDIR/destdir"
BSDINSTALL_DISTDIR="\$DESTDIR/usr/freebsd-dist"; export BSDINSTALL_DISTDIR
SRCDIR="/usr/src"

TMPDIR="\$(mktemp -d)"; export TMPDIR
for target in "\$@"; do
    BSDCFG_SHARE="\$SRCDIR/usr.sbin/bsdconfig/share" \
        BSDINSTALL_CHROOT="\$DESTDIR" \
        BSDINSTALL_CONFIGCURRENT="yes" \
        BSDINSTALL_SCRIPTS="\$BSDINSTALLDIR/scripts" \
        ./bsdinstall "\$target"
done
EOF
$ sh test.sh auto
[perform a simulated install into the "destdir" subfolder]

[khorben_defora.org]

Respect the original copyright for the "finalconfig" code.

[jrtc27]

If you're moving code around and modifying it at the same time, please make two commits / revisions so it's much easier to review what's going on. Otherwise you have to flick back and forth between files.

[khorben_defora.org]

In D41298#940467, @jrtc27 wrote:

If you're moving code around and modifying it at the same time, please make two commits / revisions so it's much easier to review what's going on. Otherwise you have to flick back and forth between files.

Understood, but then the intermediate state would not be functional, so it might also be counter-productive or dangerous to bring it in.

[jrtc27]

In D41298#941494, @khorben_defora.org wrote:

In D41298#940467, @jrtc27 wrote:

If you're moving code around and modifying it at the same time, please make two commits / revisions so it's much easier to review what's going on. Otherwise you have to flick back and forth between files.

Understood, but then the intermediate state would not be functional, so it might also be counter-productive or dangerous to bring it in.

Huh? The code is functional if you leave it alone and have the Exit entry rather than a cancel button. That’s my point; don’t make that change at the same time as moving it. Obviously you can’t always move code and literally nothing else.

[khorben_defora.org]

Replaced by D42046 and D42047.