- Collapse IDENT_SEND/IDENT_WAIT states down to a single state.
- Remove unused 'len' argument to op_data callback. The value passed in (total amount of remaining data to receive) didn't seem very useful and no op_data implementations used it.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| usr.sbin/bhyve/fwctl.c | ||
|---|---|---|
| 476 ↗ | (On Diff #125451) | So after this change, guests don't have to explicitly reset the state machine before reading the signature, but doing so is harmless. Ok, that seems fine. |
| usr.sbin/bhyve/fwctl.c | ||
|---|---|---|
| 476 ↗ | (On Diff #125451) | Humm, well, I hadn't quite realized that behavior change, but yes, I do think it's fine. |
Comment Actions
IMHO, we should get rid of fwctl. It was broken for years (https://github.com/freebsd/freebsd-src/commit/8ec366ec6c943550a011effe50bc73e3875f8ead) and nobody noticed it. So, there can't be any users.
Additionally, fwcfg serves the same use case and is a common standard.
| usr.sbin/bhyve/fwctl.c | ||
|---|---|---|
| 476 ↗ | (On Diff #125451) | Reading the signature without resetting the state machine only works for the first io read at boot up. So guests shouldn't rely on that behaviour! |