Differential D41261

cam mmc_xpt/nvme_xpt: Add _sbuf variants of {an,de}nounce xport and proto ops
ClosedPublic
Actions

Authored by jhb on Jul 31 2023, 10:26 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Oct 28, 6:20 AM

	Unknown Object (File)
	Mon, Oct 21, 3:07 AM

	Unknown Object (File)
	Sat, Oct 19, 6:48 PM

	Unknown Object (File)
	Sep 17 2024, 3:57 PM

	Unknown Object (File)
	Sep 8 2024, 4:42 PM

	Unknown Object (File)
	Sep 8 2024, 10:44 AM

	Unknown Object (File)
	Sep 7 2024, 6:32 AM

	Unknown Object (File)
	Aug 31 2024, 2:21 PM

View All 24 Files

Subscribers

Details

Reviewers

imp
mav

Group Reviewers

Commits

rG7eb538974c49: cam mmc_xpt/nvme_xpt: Add _sbuf variants of {an,de}nounce xport and proto ops

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jul 31 2023, 10:26 PM

Herald added a reviewer: cam. · View Herald TranscriptJul 31 2023, 10:26 PM

Herald added a subscriber: dab. · View Herald Transcript

jhb requested review of this revision.Jul 31 2023, 10:26 PM

Harbormaster completed remote builds in B52917: Diff 125399.Jul 31 2023, 10:26 PM

jhb added a parent revision: D41260: mmc_xpt: Remove dubious end of mmc_print_ident.Jul 31 2023, 10:26 PM

jhb added a child revision: D41262: cam_xpt: Remove fallbacks for non-sbuf protocol methods.

jhb added a parent revision: D41176: cam/nvme: Remove spurious newline during periph detach announcement.Jul 31 2023, 10:27 PM

I'm sure nvme is right. I'm pretty sure mmc is too.

This revision is now accepted and ready to land.Aug 1 2023, 2:40 PM

mav added inline comments.Aug 1 2023, 3:09 PM

sys/cam/mmc/mmc_xpt.c
418	"_sbuf()"?
430	This function is even more weird than mmc_announce_periph() -- it pstill rints nothing, but now into sbuf. ;)

jhb added inline comments.Aug 1 2023, 10:23 PM

sys/cam/mmc/mmc_xpt.c
418	I don't know that that makes much sense. Converting the other CAM_DEBUG at the bottom into a sbuf_printf() might make sense if the clock value is useful to know.
430	I don't disagree, but the non-sbuf one is going away later in the series.

Closed by commit rG7eb538974c49: cam mmc_xpt/nvme_xpt: Add _sbuf variants of {an,de}nounce xport and proto ops (authored by jhb). · Explain WhyAug 1 2023, 10:28 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG7eb538974c49: cam mmc_xpt/nvme_xpt: Add _sbuf variants of {an,de}nounce xport and proto ops.

mav added inline comments.Aug 1 2023, 11:01 PM

sys/cam/mmc/mmc_xpt.c
418	I meant just adding _sbuf to the function name in the message.

Revision Contents
Changeset List

Path

Size

sys/

cam/

mmc/

42 lines

nvme/

42 lines

Diff 125467

sys/cam/mmc/mmc_xpt.c

Loading...

sys/cam/nvme/nvme_xpt.c

Loading...