Bsdunzip from libarchive
ClosedPublic
Actions

Authored by mm on Jul 31 2023, 1:47 PM.

Details

Reviewers

des
imp
nyan

Commits

rG277283585540: unzip: swtich to bsdunzip from libarchive
rGb5a3a89c5067: unzip: swtich to bsdunzip from libarchive

Summary

Libarchive has ported the unzip(1) utility from FreeBSD. This patch switches to use bsdunzip from libarchive.
A bunch of tests is included and the test framework can be extended in the future. NetBSD will probably switch to the libarchive build and contrib to bsdunzip in libarchive, too.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

mm requested review of this revision.Jul 31 2023, 1:47 PM

mm created this revision.

nyan accepted this revision.Aug 1 2023, 12:38 PM

This revision is now accepted and ready to land.Aug 1 2023, 12:38 PM

Seems reasonable to do this.. Assuming it really is a drop in replacement...
It might make sense to do an exp run, since i'm not sure how much ports use the unzip command line vs tar.
Otherwise, no objection.

Closed by commit rGb5a3a89c5067: unzip: swtich to bsdunzip from libarchive (authored by mm). · Explain WhyAug 4 2023, 10:48 AM

This revision was automatically updated to reflect the committed changes.

mm added a commit: rGb5a3a89c5067: unzip: swtich to bsdunzip from libarchive.

mm added a commit: rG277283585540: unzip: swtich to bsdunzip from libarchive.May 4 2024, 12:38 PM