bsd.compat.mk: Provide _LIBCOMPAT alongside existing libcompat
AcceptedPublic
Actions

Authored by jrtc27 on Jul 27 2023, 10:12 PM.

Details

Reviewers

Summary

Currently there are no uses of the uppercase version when using
bsd.compat.mk with WANT/NEED_COMPAT, only within the libraries build
done by Makefile.libcompat where you instead use COMPAT_LIBCOMPAT.
However, we did used to provide this (although perhaps not as an
official interface) prior to 91d7edd549f5 ("Generalise libcompat to be a
list rather than a single option"), so let's bring it back for
completeness for any future uses that may arise.

Note that it's called _LIBCOMPAT rather than LIBCOMPAT so as to not
conflict with the src.libnames.mk variable for the library called
libcompat.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 52872
Build 49763: arc lint + arc unit

Event Timeline

jrtc27 created this revision.Jul 27 2023, 10:12 PM

Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptJul 27 2023, 10:12 PM

jrtc27 requested review of this revision.Jul 27 2023, 10:12 PM

Harbormaster completed remote builds in B52872: Diff 125260.Jul 27 2023, 10:12 PM

jrtc27 added a child revision: D41217: rtld-elf: Provide a separate specialised manpage for ld-elf32.so.1(1).Jul 27 2023, 10:15 PM

Seems unlikely it was used, but also harmless.

"uses tha may" in the message.

This revision is now accepted and ready to land.Jul 27 2023, 11:19 PM

In D41215#938737, @brooks wrote:

Seems unlikely it was used, but also harmless.

I'm pretty sure I checked at the time and didn't bother to reintroduce it as a result, but D41217 wants to use it.

Revision Contents
Changeset List

Path

Size

share/

mk/

bsd.compat.mk

1 line

Diff 125260

View Options

bsd.compat.mk: Provide _LIBCOMPAT alongside existing libcompatAcceptedPublicActions