Details
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 52828 Build 49719: arc lint + arc unit
Event Timeline
I did a brief double take the the _LIBCOMPATS diff and the -old- stuff being combined, but that's fine.
Makefile.inc1 | ||
---|---|---|
3322 | Uh, this is clearly a copy/paste error, I didn't mean to add the *.so.* (Though I do wonder why list-old-files has that for lib/ and nothing else has it for anything... obviously usr/lib at least has .a and .so symlinks, but why *doesn't* list-old-libs have this for lib/?) |
Makefile.inc1 | ||
---|---|---|
3322 | Hmm, until relatively recently (60a8277413eca3fa57f85caf331b080aee030fe5) it looks like there were some things that weren't dynamic libraries listed in OLD_LIBS. I wonder if this is a (perhaps misguided) attempt at filtering those out. |
Makefile.inc1 | ||
---|---|---|
3322 | I think I was just being somewhat paranoid about only matching real shared libraries in /lib that happened to be listed in OLD_FILES. Certainly as I worked on the patch to add the lib32 auto stuff a few months ago I was checking it against an amd64 VM I had to see how many stale things it found vs didn't find. Hmm, maybe this is to workaround this: # 200XYYZZ: /lib transition clitches OLD_FILES+=lib/libalias.so OLD_FILES+=lib/libatm.so OLD_FILES+=lib/libbsdxml.so OLD_FILES+=lib/libc.so OLD_FILES+=lib/libcam.so OLD_FILES+=lib/libcrypt.so OLD_FILES+=lib/libcrypto.so OLD_FILES+=lib/libdevstat.so OLD_FILES+=lib/libedit.so OLD_FILES+=lib/libgeom.so OLD_FILES+=lib/libipsec.so OLD_FILES+=lib/libipx.so OLD_FILES+=lib/libkvm.so OLD_FILES+=lib/libm.so OLD_FILES+=lib/libmd.so OLD_FILES+=lib/libncurses.so OLD_FILES+=lib/libreadline.so OLD_FILES+=lib/libsbuf.so OLD_FILES+=lib/libufs.so OLD_FILES+=lib/libz.so As otherwise that would break the valid symlinks in /usr/lib32. |