bsd.compat.mk Extract _ALL_LIBCOMPATS and add related variables
ClosedPublic
Actions

Authored by jrtc27 on Jul 25 2023, 7:59 PM.

Details

Reviewers

brooks
jhb
emaste
imp

Commits

rG5d6cb793d0d5: bsd.compat.mk Extract _ALL_LIBCOMPATS and add related variables

Summary

Adding these to a new bsd.compat.pre.mk will allow other parts of the
tree to iterate over the set of possible libcompats (upper and/or lower)
rather than having to hard-code the list.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 52826
Build 49717: arc lint + arc unit

Event Timeline

jrtc27 created this revision.Jul 25 2023, 7:59 PM

Herald added a subscriber: bdrewery. · View Herald TranscriptJul 25 2023, 7:59 PM

jrtc27 requested review of this revision.Jul 25 2023, 7:59 PM

Harbormaster completed remote builds in B52826: Diff 125142.Jul 25 2023, 7:59 PM

jrtc27 added child revisions: D41179: Makefile: Automatically generate list of libcompat targets, D41180: Makefile.inc1: Automatically generate _LIBCOMPATS and list-old-* libcompats, D41182: etc: Automatically generate BSD.lib${libcompat}.dist lists, D41183: libexec: Automatically generate rtld-elf list and generalise TAGS, D41184: release: Automatically generate MK_LIB${LIBCOMPAT} and lib${libcompat}-dbg lists, D41185: bsd.lib.mk: Automatically generate libcompat TAGS.Jul 25 2023, 8:05 PM

jrtc27 mentioned this in D41181: ObsoleteFiles.inc: Automatically generate OpenSSL 3 obsoleted libcompat dirs.Jul 25 2023, 8:07 PM

emaste added inline comments.Jul 25 2023, 8:10 PM

share/mk/bsd.compat.pre.mk
8–9	I think this could use a comment

Add comment to _ALL_LIBCOMPATS_libcompats

Harbormaster completed remote builds in B52838: Diff 125154.Jul 25 2023, 8:36 PM

jrtc27 marked an inline comment as done.Jul 25 2023, 8:36 PM

brooks accepted this revision.Jul 25 2023, 8:58 PM

This revision is now accepted and ready to land.Jul 25 2023, 8:58 PM

emaste accepted this revision.Jul 25 2023, 10:16 PM

jhb accepted this revision.Jul 26 2023, 8:47 PM

Closed by commit rG5d6cb793d0d5: bsd.compat.mk Extract _ALL_LIBCOMPATS and add related variables (authored by jrtc27). · Explain WhyJul 27 2023, 4:12 AM

This revision was automatically updated to reflect the committed changes.

jrtc27 added a commit: rG5d6cb793d0d5: bsd.compat.mk Extract _ALL_LIBCOMPATS and add related variables.

Revision Contents
Changeset List

Path

Size

share/

mk/

bsd.compat.mk

2 lines

bsd.compat.pre.mk

11 lines

Diff 125142

View Options

share/mk/bsd.compat.mk