Page MenuHomeFreeBSD

e1000: fixes for lem(4) and em(4) TSO
ClosedPublic

Authored by kbowling on Jul 25 2023, 3:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 28, 12:16 PM
Unknown Object (File)
Sat, Sep 28, 12:16 PM
Unknown Object (File)
Sat, Sep 28, 12:16 PM
Unknown Object (File)
Sat, Sep 28, 12:16 PM
Unknown Object (File)
Sat, Sep 28, 12:16 PM
Unknown Object (File)
Sat, Sep 28, 12:16 PM
Unknown Object (File)
Sat, Sep 28, 12:15 PM
Unknown Object (File)
Sat, Sep 28, 12:15 PM
Subscribers

Details

Summary

This patch fixes:

  • IPv6 TSO on em(4)
  • Limits TSO to IPv4 on lem(4) based on NetBSD and Linux
Test Plan

Tested on I219, 82541GI, 82546EB, VirtualBox lem(4), qemu lem(4), VMWare lem(4), VMware 82574L

TSO is not enabled on lem(4) or em(4) by default

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Owners added a reviewer: Restricted Owners Package.Jul 25 2023, 3:35 AM
sys/dev/e1000/em_txrx.c
163

I moved this here to avoid duplicating conditionals for IPv4 vs IPv6 but am open to style suggestion.

sys/dev/e1000/if_em.c
784

According to Linux lem(4) doesn't support IPv6 TSO, but they do enable TSO for IPv4 by default for (>82544, !82547). I can't see any particular reason while TSOv6 doesn't work here but intel has never been clear on all the bugs on the entire family of chips.

sys/dev/e1000/em_txrx.c
198

I added this previously based on reading the SDM noting a slightly different behavior.. but I can't think of why it would matter in reality, because you wouldn't be doing a lower (IP) checksum on IPv6 anyway.

Don't try TSO on 10/100 for lem(4)/em(4)

I agree with all of the other changes here.

sys/dev/e1000/em_txrx.c
181

Why add an extra line here?

183

I like the addition of the field names to the comment here.

shurd added inline comments.
sys/dev/e1000/if_em.c
1409

Looks like SPEED_1000 (which == 1000 of course).

Also, do any types < igb_mac_min support 2500?

sys/dev/e1000/if_em.c
1409

I think the only device covered by this driver that could possibly support 2500 link speed would be i354, which would be above igb_mac_min.

kbowling edited the test plan for this revision. (Show Details)
kbowling added reviewers: marius, shurd.

@shurd I added some smarts to the TSO automask. Also added a sysctl for people that want to opt out of.

@shurd updated automask to not require the iflib internal change.

This revision was not accepted when it landed; it landed in state Needs Review.Jul 31 2023, 3:22 PM
This revision was automatically updated to reflect the committed changes.

rebase after committed changes