Page MenuHomeFreeBSD

dtrace: Add WITH_DTRACE_ASAN.
ClosedPublic

Authored by domagoj.stolfa_gmail.com on Jul 23 2023, 2:51 PM.
Tags
None
Referenced Files
F101997326: D41157.diff
Wed, Nov 6, 8:52 AM
Unknown Object (File)
Fri, Oct 18, 2:08 AM
Unknown Object (File)
Fri, Oct 18, 2:08 AM
Unknown Object (File)
Thu, Oct 17, 11:30 PM
Unknown Object (File)
Thu, Oct 17, 5:49 PM
Unknown Object (File)
Thu, Oct 17, 5:48 PM
Unknown Object (File)
Thu, Oct 17, 5:48 PM
Unknown Object (File)
Thu, Oct 17, 5:46 PM

Details

Summary

This option is a blanket for all the DTrace-related software. The option
enables passes in -fsanitize=address -fsanitize=undefined, enabling ASAN
and UBSAN in the following components:

  • libdtrace
  • dtrace(1)
  • lockstat(1)
  • plockstat(1)

The option defaults to "no" and is intended as a developer aid.

Test Plan

Apply this patch, echo 'WITH_DTRACE_ASAN=' >> /etc/src.conf and rebuild.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 52824
Build 49715: arc lint + arc unit

Event Timeline

This is missing an option description, i.e., tools/build/options/WITH_DTRACE_ASAN needs to be added.

Add tools/build/options/WITH_DTRACE_ASAN and update src.conf.

If there's any other preference for the text that should be contained in the man pages, I would be happy to replace it.

markj added inline comments.
tools/build/options/WITH_DTRACE_ASAN
3
This revision is now accepted and ready to land.Jul 25 2023, 1:24 PM
tools/build/options/WITH_DTRACE_ASAN
2

$FreeBSD$ is no longer needed, you can leave it out

Address the comments by markj and emaste.

This revision now requires review to proceed.Jul 25 2023, 5:58 PM

Add a missing newline to the option file and regenerate src.conf.5.

This revision is now accepted and ready to land.Jul 26 2023, 2:34 PM

Could you please mail me a git diff to apply to main?

This revision was automatically updated to reflect the committed changes.