Details
Details
- Reviewers
- None
- Group Reviewers
cam
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 52703 Build 49594: arc lint + arc unit
Event Timeline
Comment Actions
Revert c5312bd79e66ce8ef50655ce7f3eca06d6b6e24f. and then apply this.
This is for discussion only at the moment.
In this fix, we rename memdesc_ccb to cam_memdesc_ccb and make it a static inline in cam_ccb.h
Comment Actions
I don't feel strongly that we need to rename it. We don't call bus_dmamap_load_ccb, cam_bus_dmamap_load_ccb for example. However, the function is also a bit different now. I wonder which manpage you would want to put it in for example? Would it be some generic cam_ccb(9) or would it belong in a memdesc(9)? I can sort of see arguments both ways.
| sys/cam/cam_ccb.h | ||
|---|---|---|
| 1556 | Maybe a blank line before the #ifdef? | |