Obsoletefiles.inc: A few OpenSSL 3 cleanups.
ClosedPublic
Actions

Authored by jhb on Jul 13 2023, 11:50 PM.

Details

Reviewers

emaste
khorben_defora.org

Commits

rGa248abb55a51: Obsoletefiles.inc: A few OpenSSL 3 cleanups.

Summary

Treat old engine DSOs from OpenSSL 1.1.1 as OLD_LIBS, not OLD_FILES. These should only be deleted by make delete-old-libs similar to how PAM modules are treated.

Add /usr/lib32/engines to OLD_DIRS. lib32 automation does not apply to OLD_DIRS.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 52639
Build 49530: arc lint + arc unit

Event Timeline

jhb created this revision.Jul 13 2023, 11:50 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 13 2023, 11:50 PM

jhb requested review of this revision.Jul 13 2023, 11:50 PM

Harbormaster completed remote builds in B52639: Diff 124649.Jul 13 2023, 11:50 PM

jhb added a reviewer: khorben_defora.org.Jul 14 2023, 12:15 AM

Thanks for the patch and explanation!
Did you not mean OLD_LIBS instead of OLD_DIRS for capi.so and padlock.so inside the patch itself?

Oh dear, yes.

Use OLD_LIBS for real

Harbormaster completed remote builds in B52652: Diff 124682.Jul 14 2023, 4:30 PM

LGTM!

This revision is now accepted and ready to land.Jul 14 2023, 5:16 PM

Closed by commit rGa248abb55a51: Obsoletefiles.inc: A few OpenSSL 3 cleanups. (authored by jhb). · Explain WhyJul 14 2023, 5:27 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGa248abb55a51: Obsoletefiles.inc: A few OpenSSL 3 cleanups..

Revision Contents
Changeset List

Path

Size

ObsoleteFiles.inc

5 lines

Diff 124649

View Options

Obsoletefiles.inc: A few OpenSSL 3 cleanups.ClosedPublicActions