arm64 lib32: change clang to allow -m32 on arm64

[• karels]

Summary

The FreeBSD driver support for clang tested explicitly for 32-bit
Intel, MIPS, or PowerPC targets where /usr/lib32/libcrt1.o was
present to decide whether -m32 should use /usr/lib32. At jrtc27's
suggestion, simply test for a 32-bit platform rather than adding
arm to the list. This is one step in adding support for -m32 on
arm64.

[• karels]

@dim, we need a way to force the make system to bootstrap a compiler with this change, or the lib32 build breaks. Can we change the version string, etc?

[jrtc27]

Bump lib/clang/freebsd_cc_version.h

[dim]

Indeed, bumping lib/clang/freebsd_cc_version.h is the way to force a bootstrap clang rebuild. The change to clang/lib/Driver/ToolChains/FreeBSD.cpp should also be upstreamed.

[• karels]

In D40943#932160, @dim wrote:

Indeed, bumping lib/clang/freebsd_cc_version.h is the way to force a bootstrap clang rebuild. The change to clang/lib/Driver/ToolChains/FreeBSD.cpp should also be upstreamed.

Thanks, I didn't realize that there is a FreeBSD-specific version; that helps.

How do we go about upstreaming?

[jrtc27]

In D40943#932172, @karels wrote:

In D40943#932160, @dim wrote:

Indeed, bumping lib/clang/freebsd_cc_version.h is the way to force a bootstrap clang rebuild. The change to clang/lib/Driver/ToolChains/FreeBSD.cpp should also be upstreamed.

Thanks, I didn't realize that there is a FreeBSD-specific version; that helps.

How do we go about upstreaming?

It's trivial enough I just committed it directly: https://github.com/llvm/llvm-project/commit/3450272fc281979388bb845a9fffb59b42cc2e7e

[• karels]

Bump freebsd version number.

[brooks]

I've merged this back through llvm13. I'll let the changes settle for a day and then merge to quarterly so CI can use them.

[jrtc27]

Please add a pointer to the upstream commit when committing this so it's clear this isn't a downstream diff

[• karels]

In D40943#937935, @jrtc27 wrote:

Please add a pointer to the upstream commit when committing this so it's clear this isn't a downstream diff

Already done in my copy.