compat
ClosedPublic
Actions

Authored by mhorne on Jul 4 2023, 6:45 PM.

Details

Reviewers

grahamperrin
• karels
dchagin

Group Reviewers

Linux Emulation

Commits

rG18ca9e6c5ff1: hier(7): remove entry for non-existent /usr/compat
rG5e7308a7bcb6: hier(7): remove entry for non-existent /usr/compat

Summary

This is historical (?), but today /compat is the default according to
linux(4). The only remaining reference to /usr/compat in the src tree is
under tools/test/stress2.

PR: 261349

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 52435
Build 49326: arc lint + arc unit

Event Timeline

mhorne created this revision.Jul 4 2023, 6:45 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 4 2023, 6:45 PM

mhorne requested review of this revision.Jul 4 2023, 6:45 PM

Harbormaster completed remote builds in B52435: Diff 124180.Jul 4 2023, 6:45 PM

mhorne added a reviewer: Linux Emulation.Jul 4 2023, 6:46 PM

dchagin accepted this revision as: dchagin.Jul 4 2023, 6:54 PM

This revision is now accepted and ready to land.Jul 4 2023, 6:54 PM

Looks fine to me too.

grahamperrin added inline comments.Jul 4 2023, 8:56 PM

share/man/man7/hier.7
82	https://github.com/freebsd/freebsd-src/blob/main/sys/README.md describes `/usr/src/sys/compat/` as, more broadly: Linux compatibility layer, FreeBSD 32-bit compatibility Should `/compat/` have a similar description in hier(7), or have I taken the README for source out of context?

• karels added inline comments.Jul 4 2023, 10:47 PM

share/man/man7/hier.7
82	No, the two are not really related, although Linux figures in both.

grahamperrin added inline comments.Jul 5 2023, 4:17 AM

share/man/man7/hier.7
82	@karels thanks … so (for hier(7)) the other operating systems are always Linux-based, true?

imp added inline comments.Jul 5 2023, 4:24 AM

share/man/man7/hier.7
82	I thought /compat/linux was used by the linuxulator... and /compat/baz was reserved for the foo emulator. Both for when they are looking up object /bar/foo that is backed by /compat/bar/foo because the native /bar/foo was inappropriate somehow

imp added inline comments.Jul 5 2023, 4:27 AM

share/man/man7/hier.7
82	s/foo emulator/baz emulator/ in my comment...

• karels added inline comments.Jul 5 2023, 11:57 AM

share/man/man7/hier.7
82	As far as I know, linux is the only emulator supported currently, although there could be others. I think the current text is fine.

Add a second-level entry for /compat/linux. Rendered as:

/compat/   files needed to support binary compatibility with other
           operating systems

           linux/        default location for linux(4) compatibility run-
                         time

/dev/      the normal mount point for devfs(5)

           fd/           file descriptor files; see fd(4)

This revision now requires review to proceed.Jul 5 2023, 3:17 PM

Harbormaster completed remote builds in B52439: Diff 124198.Jul 5 2023, 3:17 PM

dchagin accepted this revision as: dchagin.Jul 5 2023, 10:49 PM

This revision is now accepted and ready to land.Jul 5 2023, 10:49 PM

Approved as is.

If you like, remove a superfluous word.

Thanks!