Page MenuHomeFreeBSD
Differential D40832

divmoddi4: Handle negative remainders.
ClosedPublic
Actions

Authored by jhb on Jul 1 2023, 9:32 PM.
Tags
None
Referenced Files
F108445646: D40832.diff
Fri, Jan 24, 8:32 PM
F108429663: D40832.id.diff
Fri, Jan 24, 5:20 PM
Unknown Object (File)
Dec 2 2024, 7:55 AM
Unknown Object (File)
Dec 2 2024, 7:55 AM
Unknown Object (File)
Dec 2 2024, 7:55 AM
Unknown Object (File)
Dec 2 2024, 7:21 AM
Unknown Object (File)
Nov 1 2024, 3:09 PM
Unknown Object (File)
Sep 18 2024, 11:09 PM
View All 41 Files
Subscribers
imp

Details

Reviewers
jrtc27
Commits
rGdf11fb9bf042: divmoddi4: Handle negative remainders.
Summary

The sign of the remainder matches the sign of the numerator in C.

Reported by: jrtc27

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 52376
Build 49267: arc lint + arc unit

Event Timeline

jhb created this revision.Jul 1 2023, 9:32 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 1 2023, 9:32 PM
jhb requested review of this revision.Jul 1 2023, 9:32 PM
Harbormaster completed remote builds in B52376: Diff 124080.Jul 1 2023, 9:32 PM
jrtc27 accepted this revision.Jul 1 2023, 9:35 PM

negq = negr = [01] is slightly shorter and what I did but eh, debatable which is clearer

This revision is now accepted and ready to land.Jul 1 2023, 9:35 PM
jrtc27 added inline comments.Jul 1 2023, 9:36 PM
sys/libkern/divmoddi4.c
58
Closed by commit rGdf11fb9bf042: divmoddi4: Handle negative remainders. (authored by jhb). · Explain WhyJul 1 2023, 9:45 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGdf11fb9bf042: divmoddi4: Handle negative remainders..

Revision Contents
Changeset List

PathSize
sys/
libkern/
12 lines

Diff 124080

View Options

sys/libkern/divmoddi4.c

Loading...