stdbuf: Code cleanup.
ClosedPublic
Actions

Authored by des on Jun 29 2023, 3:17 PM.

Details

Reviewers

jlh
kevans
imp

Group Reviewers

Klara

Commits

rGe4dee290ff0b: stdbuf: Code cleanup.
rG78baa632092a: stdbuf: Code cleanup.

Summary

Factor out path-setting code.
Normalize usage().

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Jun 29 2023, 3:17 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 29 2023, 3:17 PM

des requested review of this revision.Jun 29 2023, 3:17 PM

Harbormaster completed remote builds in B52333: Diff 123985.Jun 29 2023, 3:18 PM

kevans accepted this revision.Jun 29 2023, 3:26 PM

kevans added a subscriber: kevans.

kevans added inline comments.

usr.bin/stdbuf/stdbuf.c
84–85	I'd probably drop this and just let it fall into the default cause, no need to be verbose here.

This revision is now accepted and ready to land.Jun 29 2023, 3:26 PM

better variable names

This revision now requires review to proceed.Jun 29 2023, 3:26 PM

Harbormaster completed remote builds in B52334: Diff 123986.Jun 29 2023, 3:26 PM

review feedback

des marked an inline comment as done.Jun 29 2023, 3:28 PM

imp accepted this revision.Jun 29 2023, 3:28 PM

This revision is now accepted and ready to land.Jun 29 2023, 3:28 PM

kevans accepted this revision.Jun 29 2023, 3:28 PM

Harbormaster completed remote builds in B52335: Diff 123987.Jun 29 2023, 3:29 PM

Closed by commit rG78baa632092a: stdbuf: Code cleanup. (authored by des). · Explain WhyJun 29 2023, 3:32 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG78baa632092a: stdbuf: Code cleanup..

des added a commit: rGe4dee290ff0b: stdbuf: Code cleanup..Sep 7 2023, 2:52 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

stdbuf/

stdbuf.c

52 lines

Diff 123988

View Options

stdbuf: Code cleanup.ClosedPublicActions