bhyve: Stop calling pci_lintr_request() in the NVMe device model
ClosedPublic
Actions

Authored by markj on Jun 23 2023, 10:02 PM.

Details

Reviewers

chuck
corvink
jhb

Group Reviewers

bhyve

Commits

rGa53a2971ac3f: bhyve: Stop calling pci_lintr_request() in the NVMe device model
rG13013d266e77: bhyve: Stop calling pci_lintr_request() in the NVMe device model

Summary

The device model effectively assumes that MSI-X is enabled (it never
asserts the legacy interrupt), so any guest which relies on being able
to use the legacy PCI interrupt will fail.

The WIP arm64 port does not implement legacy PCI interrupts, but NVMe
emulation is potentially useful there. Simply remove the call.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 52265
Build 49156: arc lint + arc unit

Event Timeline

markj created this revision.Jun 23 2023, 10:02 PM

Herald added a reviewer: bhyve. · View Herald TranscriptJun 23 2023, 10:02 PM

Herald added subscribers: dab, bcran, rgrimes, imp. · View Herald Transcript

markj requested review of this revision.Jun 23 2023, 10:02 PM

Harbormaster completed remote builds in B52265: Diff 123695.Jun 23 2023, 10:03 PM

corvink accepted this revision.Jun 26 2023, 6:01 AM

This revision is now accepted and ready to land.Jun 26 2023, 6:01 AM

chuck accepted this revision.Jun 27 2023, 6:30 PM

jhb accepted this revision.Jun 27 2023, 7:28 PM

FWIW, I was able to boot an Alma Linux VM with this change

Closed by commit rG13013d266e77: bhyve: Stop calling pci_lintr_request() in the NVMe device model (authored by markj). · Explain WhyJun 28 2023, 8:47 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG13013d266e77: bhyve: Stop calling pci_lintr_request() in the NVMe device model.

markj added a commit: rGa53a2971ac3f: bhyve: Stop calling pci_lintr_request() in the NVMe device model.Aug 1 2023, 1:57 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

pci_nvme.c

2 lines

Diff 123695

View Options

bhyve: Stop calling pci_lintr_request() in the NVMe device modelClosedPublicActions