subr_blist: end ffs backup
ClosedPublic
Actions

Authored by dougm on Jun 21 2023, 5:52 PM.

Details

Reviewers

alc
mhorne

Commits

rGd4e236c70b0d: inline_ffs: remove backup binary implementation

Summary

After D40698 is committed, there will no longer be any point to maintaining a binary search routine for ffs; inlines will always do it as well or better.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dougm requested review of this revision.Jun 21 2023, 5:52 PM

dougm created this revision.

mhorne accepted this revision.Jun 21 2023, 8:31 PM

mhorne added inline comments.

sys/kern/subr_blist.c
191–193	`_Static_assert` is to be preferred (see CTASSERT(9)). And why not `==`?

This revision is now accepted and ready to land.Jun 21 2023, 8:31 PM

Wrong button :)

This revision now requires changes to proceed.Jun 21 2023, 8:31 PM

Switch CTASSERT to _Static_assert.

mhorne accepted this revision.Jun 22 2023, 7:45 PM

This revision is now accepted and ready to land.Jun 22 2023, 7:45 PM

dougm added inline comments.Jul 3 2023, 6:13 AM

sys/kern/subr_blist.c
191–193	I'll change to _Static_assert. If somebody someday makes a change that makes u_daddr_t 32-bits on some architecture, should this assert fail for that architecture? fffsll will still work correctly.