fdescfs: improve linrdlnk mount option
ClosedPublic
Actions

Authored by kib on Jun 21 2023, 4:42 PM.

Details

Reviewers

Commits

rG4a402dfe0bc4: VFS: Remove VV_READLINK flag
rG3bffa2262328: fdescfs: improve linrdlnk mount option

Summary

Instead of using VV_READLINK vnode flag and checking it in one place,
just assign VLNK type to the Fdesc vnodes for linrdlnk mounts.  Then all
places where symlinks needs to be followed, e.g. lookup(), are handled.

Remove VV_READLINK flag, since its only reason to exist is removed.

PR:     272127
Reported by:    Peter Eriksson <pen@lysator.liu.se>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Jun 21 2023, 4:42 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 21 2023, 4:42 PM

kib requested review of this revision.Jun 21 2023, 4:42 PM

As a second thought: if vn_fullpath() for the filedescriptor N vnode failed, fd/N symlink cannot be resolved. This would cause somewhat strange failure mode for lookups, but I believe this issue is present with the pristine HEAD as well.

A 13.2-RELEASE kernel built with the changes above seems to fix my issue.

markj accepted this revision.Jun 23 2023, 4:04 PM

This revision is now accepted and ready to land.Jun 23 2023, 4:04 PM

Closed by commit rG3bffa2262328: fdescfs: improve linrdlnk mount option (authored by kib). · Explain WhyJun 27 2023, 10:44 AM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG3bffa2262328: fdescfs: improve linrdlnk mount option.

kib added a commit: rG4a402dfe0bc4: VFS: Remove VV_READLINK flag.

kib added a reverting change: D40969: Re-implement fix for PR 272127 by dedicated mount option.Jul 11 2023, 5:14 AM

kib added a reverting change: rG9c3bfe2ad071: Revert "VFS: Remove VV_READLINK flag" and "fdescfs: improve linrdlnk mount….Jul 13 2023, 1:18 AM