riscv: Remove MACHINE_ARCH-specific remnants of riscv64sf.
ClosedPublic
Actions

Authored by jhb on Jun 20 2023, 4:31 PM.

Details

Reviewers: None
Commits: rG36c2fec31dd6: riscv: Remove MACHINE_ARCH-specific remnants of riscv64sf.

Summary

Remove now unnecessary MACHINE_ARCHES definition. The default logic in kern_mib.c works fine now for RISC-V.

Remove custom sv_machine_arch hook from sysentvec.

Fixes: 1ca12bd927d7 Remove the riscv64sf architecture.
Sponsored by: DARPA

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jun 20 2023, 4:31 PM

Herald added subscribers: riscv, imp. · View Herald TranscriptJun 20 2023, 4:31 PM

jhb requested review of this revision.Jun 20 2023, 4:31 PM

Harbormaster completed remote builds in B52183: Diff 123522.Jun 20 2023, 4:31 PM

Can possibly remove MACHINE_ARCHES and sv_machine_arch as a followup as they are no longer used after this.

In D40648#925283, @jhb wrote:

Can possibly remove MACHINE_ARCHES and sv_machine_arch as a followup as they are no longer used after this.

So does CHERI or any out-of-the-tree user need them?

also, we do use MACHINE_ARCHES for the kern.supported_arch sysctl, though after this change we could make that #define purely internal to kern_mib.c ...

In D40648#925495, @imp wrote:

In D40648#925283, @jhb wrote:

Can possibly remove MACHINE_ARCHES and sv_machine_arch as a followup as they are no longer used after this.

So does CHERI or any out-of-the-tree user need them?

also, we do use MACHINE_ARCHES for the kern.supported_arch sysctl, though after this change we could make that #define purely internal to kern_mib.c ...

CHERI does not use it no. CheriBSD has a MACHINE_ARCH64 helper similar to MACHINE_ARCH32 and handles it all internal to kern_mib.c as well. I think only soft-float arches (MIPS and RISC-V) used this feature previously.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 27 2023, 5:19 PM

Closed by commit rG36c2fec31dd6: riscv: Remove MACHINE_ARCH-specific remnants of riscv64sf. (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG36c2fec31dd6: riscv: Remove MACHINE_ARCH-specific remnants of riscv64sf..