Page MenuHomeFreeBSD

Fix some shell issues by adding quotes in fwget.sh
ClosedPublic

Authored by bcr on Jun 19 2023, 9:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 7, 1:44 PM
Unknown Object (File)
Sun, Dec 29, 3:11 AM
Unknown Object (File)
Fri, Dec 27, 7:07 PM
Unknown Object (File)
Oct 11 2024, 7:25 AM
Unknown Object (File)
Oct 11 2024, 7:12 AM
Unknown Object (File)
Oct 10 2024, 10:15 PM
Unknown Object (File)
Oct 1 2024, 2:22 PM
Unknown Object (File)
Oct 1 2024, 2:14 AM
Subscribers

Details

Summary

This patch fixes the following issues in the shell script:

  • Quote default assignments, see SC2223
  • Use $() instead of backticks, see SC2006
  • Double quote $@, see SC2068
  • Double quote variables in if-statements and other places, see SC2086

While here, fix a whitespace at end of line instance in the license text.

Test Plan
  1. Apply the patch to /usr.sbin/fwget
  2. Run fwget to see if it still works

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped