camcontrol: Add support for -r XX to set reserved bits in defects
AbandonedPublic
Actions

Authored by imp on Jun 13 2023, 9:26 PM.

Details

Reviewers

ken
mav

Summary

Some drives can return additional defect information by setting
the higher order bits in byte 2 of the READ DEFECT DATA commands
(both of them). Allow these to be set.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 52034
Build 48925: arc lint + arc unit

Event Timeline

imp requested review of this revision.Jun 13 2023, 9:26 PM

imp created this revision.

Harbormaster completed remote builds in B52034: Diff 123178.Jun 13 2023, 9:26 PM

imp added a parent revision: D40524: camcontrol: simplify summary logic for defects.Jun 13 2023, 9:26 PM

imp added a child revision: D40526: camcontrol: In defects make -S actually imply 12-byte command.

imp added reviewers: ken, mav.Jun 13 2023, 9:28 PM

If you have use for it...

This revision is now accepted and ready to land.Jun 15 2023, 2:06 PM

In D40525#923414, @mav wrote:

If you have use for it...

I believe I have a use for it... Once that's confirmed by putting it into production I'll push this in. If it turns out to be a dry well, I'll keep it in reserve for the future.

I'm letting this one linger a bit... It's unclear if $WORK needs this feature or not, so leaving
open for now.

This turns out not to be needed for the thing the vendor was telling me to do. Their firmware didn't behave like they thought it would, and the solution is along a different path. So, rather than add a useless feature, I'm punting.