Page MenuHomeFreeBSD

HWT: ARM CoreSight support
Needs ReviewPublic

Authored by br on Jun 9 2023, 3:06 PM.
Tags
None
Referenced Files
F108594216: D40477.id125527.diff
Sun, Jan 26, 6:16 PM
F108593428: D40477.id123010.diff
Sun, Jan 26, 6:09 PM
F108592670: D40477.id125347.diff
Sun, Jan 26, 6:02 PM
F108591841: D40477.id124428.diff
Sun, Jan 26, 5:54 PM
Unknown Object (File)
Fri, Jan 24, 6:01 PM
Unknown Object (File)
Fri, Jan 24, 5:59 PM
Unknown Object (File)
Fri, Jan 24, 5:56 PM
Unknown Object (File)
Fri, Jan 24, 5:50 PM

Details

Summary
  • Add ARM Coresight (SoC-400) support to HWT framework
  • Pipeline build code added
Test Plan

Tested on ARM Morello platform.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br requested review of this revision.Jun 9 2023, 3:06 PM

Add CORESIGHT_DEBUG macro.

Provide the name of backend needed for registration in HWT framework.

Interface to HWT changed

morello-dts included for test

Make coresight optional. Depends on hwt

coresight_setup() method added

hwt_backend interface changed

Kernel-mode tracing support added.

allow tracing multiple cpus in system mode

ability to build as a module

sys/arm64/coresight/coresight.c
67

Should we dynamically allocate this based on mp_ncpus instead, especially since MAXCPU is being bumped to 1024? I think it would make sense to do that in coresight_backend_init and then can free() at the end of coresight_backend_deinit.

This is what I'm doing for SPE at the moment.

br removed a reviewer: manu.

Pass ctx to backend_deinit().

This doesn't build when I add hwt and coresight to my kernel config

Due to pipeline design Coresight components could not be used for more than 1 concurrent tracing sessions.
Atomic counter of sessions added and limited to 1.

This doesn't build when I add hwt and coresight to my kernel config

Could you try again? A change in modules/Makefile was missing