So.. looks good to me...
It would be awesome if we could automatically detect this quirk... maybe if the probe works turn the rest off? If you are up for trying that...
If not, this can go in as is...

imp accepted this revision.Jun 3 2023, 4:50 AM

This revision is now accepted and ready to land.Jun 3 2023, 4:50 AM

If not, this can go in as is...

Do I have to do anything else for it to be committed?

In D40405#928098, @jon_thesoo.org wrote:

If not, this can go in as is...

Do I have to do anything else for it to be committed?

I was waiting for one of (1) Here's the code to do the quirk automatically or (2) No clue how to automate. Sounds like you are much closer to (2) than (1), which is fine :)

Ok,

I'm not sure what the Chromebook id permutations are. I don't have a more general solution for this issue.

No need to close it. An additional quirk is fine. I'll commit it today

This revision is now accepted and ready to land.Jun 28 2023, 4:26 PM

Closed by commit rG599a4548f8f1: Adds support for Purism coreboot keyboards (authored by jon_thesoo.org, committed by imp). · Explain WhyJun 28 2023, 5:20 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG599a4548f8f1: Adds support for Purism coreboot keyboards.

imp added a reverting change: D40787: atkbd: Flip the default for 'coreboot' to being normal.Jun 28 2023, 5:47 PM