unbound: avoid calling deprecated OpenSSL function
ClosedPublic
Actions

Authored by emaste on May 30 2023, 9:42 PM.

Tags

None

Referenced Files

	F101990286: D40341.diff
	Wed, Nov 6, 6:28 AM

	Unknown Object (File)
	Mon, Oct 21, 12:35 AM

	Unknown Object (File)
	Sun, Oct 20, 3:41 AM

	Unknown Object (File)
	Sun, Oct 20, 3:41 AM

	Unknown Object (File)
	Sun, Oct 20, 3:41 AM

	Unknown Object (File)
	Sun, Oct 20, 3:22 AM

	Unknown Object (File)
	Fri, Oct 11, 1:53 PM

	Unknown Object (File)
	Sep 14 2024, 8:29 AM

View All 59 Files

Subscribers

imp

Details

Reviewers

des
khorben_defora.org
ngie

Commits

rGdc103686348d: unbound: avoid calling deprecated OpenSSL function

Summary

SSL_CTX_set_ecdh_auto is deprecated and has no effect (for reference see https://github.com/openssl/openssl/commit/2ecb9f2d18614fb7b7b42830a358b7163ed43221).

As unbound's config.h is manually maintained just turn off HAVE_DECL_SSL_CTX_SET_ECDH_AUTO so that it won't be called.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.May 30 2023, 9:42 PM

emaste created this revision.

emaste added a reviewer: ngie.

Sounds good to me! From https://www.openssl.org/docs/man3.1/man3/SSL_CTX_set_ecdh_auto.html :

SSL_CTX_set_ecdh_auto() and SSL_set_ecdh_auto() are deprecated and have no effect.

Oddly enough this function doesn't appear to be documented on 1.1..

This revision is now accepted and ready to land.May 30 2023, 11:10 PM

Closed by commit rGdc103686348d: unbound: avoid calling deprecated OpenSSL function (authored by emaste). · Explain WhyMay 30 2023, 11:56 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGdc103686348d: unbound: avoid calling deprecated OpenSSL function.

Herald added a subscriber: imp. · View Herald TranscriptMay 30 2023, 11:56 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

unbound/

config.h

2 lines

Diff 122630

View Options

unbound: avoid calling deprecated OpenSSL functionClosedPublicActions