Page MenuHomeFreeBSD
Differential D40246

LinuxKPI: add ktime_get_real_ts64()
ClosedPublic
Actions

Authored by bz on May 23 2023, 11:20 PM.
Tags
None
Referenced Files
F101894600: D40246.diff
Tue, Nov 5, 8:00 AM
Unknown Object (File)
Mon, Nov 4, 5:23 AM
Unknown Object (File)
Sun, Nov 3, 8:43 AM
Unknown Object (File)
Mon, Oct 28, 4:30 PM
Unknown Object (File)
Sat, Oct 26, 7:05 PM
Unknown Object (File)
Wed, Oct 16, 2:41 AM
Unknown Object (File)
Mon, Oct 14, 9:47 PM
Unknown Object (File)
Mon, Oct 14, 7:46 AM
View All 88 Files
Subscribers
emaste
imp

Details

Reviewers
emaste
Group Reviewers
linuxkpi
Commits
rG9a37368d2beb: LinuxKPI: add ktime_get_real_ts64()
rGb889315da300: LinuxKPI: add ktime_get_real_ts64()
Summary

Add a wrapper for ktime_get_real_ts64() used by a wireless driver.

MFC after: 10 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 51655
Build 48546: arc lint + arc unit

Event Timeline

bz created this revision.May 23 2023, 11:20 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptMay 23 2023, 11:20 PM
bz requested review of this revision.May 23 2023, 11:20 PM
Harbormaster completed remote builds in B51655: Diff 122341.May 23 2023, 11:20 PM
emaste added a comment.May 23 2023, 11:47 PM

I'm not sure if this one needs to be the non-get version, could be getnanotime?

bz added a comment.May 24 2023, 8:41 AM
In D40246#916350, @emaste wrote:

I'm not sure if this one needs to be the non-get version, could be getnanotime?

Neither am I. We do use nanotime() for ktime_get_real and ktime_get_real_seconds and then convert it.
My understanding was that our "get*" version was faster and less precise so I figured I'll follow the other "real" cases already in the file?

emaste added a comment.May 24 2023, 12:32 PM

AFAICT "real" refers to it being time of day, rather than not-cached.

bz updated this revision to Diff 122686.May 31 2023, 10:10 PM

Switch to get-version as pointed out by @emaste.

Harbormaster completed remote builds in B51820: Diff 122686.May 31 2023, 10:10 PM
emaste accepted this revision.Jun 1 2023, 1:29 AM
This revision is now accepted and ready to land.Jun 1 2023, 1:29 AM
Closed by commit rGb889315da300: LinuxKPI: add ktime_get_real_ts64() (authored by bz). · Explain WhyJun 8 2023, 5:59 PM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rGb889315da300: LinuxKPI: add ktime_get_real_ts64().
bz added a commit: rG9a37368d2beb: LinuxKPI: add ktime_get_real_ts64().Jun 26 2023, 12:09 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
1 line

Diff 122341

View Options

sys/compat/linuxkpi/common/include/linux/ktime.h

Loading...