ofw_cpu: quiet secondary CPU devices
ClosedPublic
Actions

Authored by mhorne on May 23 2023, 5:51 PM.

Details

Reviewers

manu
jhb

Group Reviewers

arm64
riscv

Commits

rGe61a69e88a03: ofw_cpu: quiet secondary CPU devices
rG08637d5d1580: ofw_cpu: quiet secondary CPU devices

Summary

We already do plenty to announce the different CPUs in dmesg. Follow the
ACPI CPU strategy of reporting the first CPU device, but quieting the
rest for non-verbose boot. This cuts down slightly on dmesg output.

Test Plan

dmesg output from an RPI4. Before:

cpulist0: <Open Firmware CPU Group> on ofwbus0
cpu0: <Open Firmware CPU> on cpulist0
bcm2835_cpufreq0: <CPU Frequency Control> on cpu0
cpu1: <Open Firmware CPU> on cpulist0
cpu2: <Open Firmware CPU> on cpulist0
cpu3: <Open Firmware CPU> on cpulist0

After:

cpulist0: <Open Firmware CPU Group> on ofwbus0
cpu0: <Open Firmware CPU> on cpulist0
bcm2835_cpufreq0: <CPU Frequency Control> on cpu0

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.May 23 2023, 5:51 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 23 2023, 5:51 PM

mhorne requested review of this revision.May 23 2023, 5:51 PM

mhorne added a parent revision: D40242: ofw_cpu: whitespace cleanup.

Harbormaster completed remote builds in B51648: Diff 122326.May 23 2023, 5:51 PM

mhorne edited the test plan for this revision. (Show Details)May 23 2023, 5:51 PM

jhb accepted this revision.May 23 2023, 9:04 PM

This revision is now accepted and ready to land.May 23 2023, 9:04 PM

manu accepted this revision.May 24 2023, 6:40 AM

Closed by commit rG08637d5d1580: ofw_cpu: quiet secondary CPU devices (authored by mhorne). · Explain WhyMay 24 2023, 1:29 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rG08637d5d1580: ofw_cpu: quiet secondary CPU devices.

mhorne added a commit: rGe61a69e88a03: ofw_cpu: quiet secondary CPU devices.Jun 9 2023, 8:04 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

ofw/

ofw_cpu.c

5 lines

Diff 122370

View Options

ofw_cpu: quiet secondary CPU devicesClosedPublicActions