Page MenuHomeFreeBSD
Differential D40180

ifconfig: simplify ifconfig() by factoring out ifa add/del logic
ClosedPublic
Actions

Authored by melifaro on May 20 2023, 11:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 27, 12:08 PM
Unknown Object (File)
Wed, Sep 25, 9:10 PM
Unknown Object (File)
Wed, Sep 25, 12:28 AM
Unknown Object (File)
Sat, Sep 21, 12:41 PM
Unknown Object (File)
Thu, Sep 5, 5:22 AM
Unknown Object (File)
Tue, Sep 3, 7:09 PM
Unknown Object (File)
Sun, Sep 1, 3:33 PM
Unknown Object (File)
Aug 31 2024, 5:51 PM
View All 50 Files
Subscribers
imp

Details

Reviewers
kp
Group Reviewers
network
Commits
rG63ad5ce7335b: ifconfig: simplify ifconfig() by factoring out ifa add/del logic

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

melifaro created this revision.May 20 2023, 11:23 AM
Herald added a subscriber: imp. · View Herald TranscriptMay 20 2023, 11:23 AM
melifaro requested review of this revision.May 20 2023, 11:23 AM
Harbormaster completed remote builds in B51576: Diff 122160.May 20 2023, 11:23 AM
melifaro added a parent revision: D40179: ifconfig: split argument parsing.May 20 2023, 11:24 AM
melifaro edited the summary of this revision. (Show Details)
melifaro added reviewers: network, kp.
melifaro added a child revision: D40182: ifconfig: switch IPv4/IPv6 address manipulations to Netlink.May 20 2023, 11:54 AM
kp accepted this revision as: kp.May 20 2023, 3:39 PM
kp added inline comments.
sbin/ifconfig/ifconfig.c
977

Not blocking here, but we really need to reduce the number of global variables in ifconfig.

983

I think style(9) still requires that declaration to be at the top of a block.

This revision is now accepted and ready to land.May 20 2023, 3:39 PM
melifaro marked an inline comment as done.May 21 2023, 9:42 AM
melifaro added inline comments.
sbin/ifconfig/ifconfig.c
977

I agree - that's why I started their merge under args. This diff has a specific scope of simplifying ifconfig() function and it doesn't change anything w.r.t the global variable handling.

Closed by commit rG63ad5ce7335b: ifconfig: simplify ifconfig() by factoring out ifa add/del logic (authored by melifaro). · Explain WhyMay 21 2023, 9:43 AM
This revision was automatically updated to reflect the committed changes.
melifaro added a commit: rG63ad5ce7335b: ifconfig: simplify ifconfig() by factoring out ifa add/del logic.

Revision Contents
Changeset List

PathSize
sbin/
ifconfig/
83 lines

Diff 122181

View Options

sbin/ifconfig/ifconfig.c

Loading...