cpufreq(4): calculate power if P-state info comes from MSR
ClosedPublic
Actions

Authored by jo_bruelltuete.com on May 18 2023, 12:44 AM.

Details

Reviewers

markj
cem

Commits

rGb44b64eeff1d: hwpstate_amd: calculate power if P-state info comes from MSR
rGe74dd9577fb0: hwpstate_amd: calculate power if P-state info comes from MSR

Test Plan

The numbers coming out match what my BIOS comes up with.
And looking at the sparse documentation available, the calculation is spec'd by AMD.

dev.cpu.0.freq_levels: 3600/3960 2800/2800 2200/1980
dev.cpu.0.freq: 2200

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

jo_bruelltuete.com created this revision.May 18 2023, 12:44 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 18 2023, 12:44 AM

jo_bruelltuete.com requested review of this revision.May 18 2023, 12:44 AM

jo_bruelltuete.com added inline comments.

sys/x86/cpufreq/hwpstate_amd.c
492	is there an integer-pow available in kernel mode?

jo_bruelltuete.com edited the test plan for this revision. (Show Details)May 18 2023, 12:46 AM

jo_bruelltuete.com added a reviewer: cem.May 18 2023, 3:43 PM

cem resigned from this revision.May 18 2023, 4:29 PM

markj accepted this revision.May 22 2023, 4:23 PM

This revision is now accepted and ready to land.May 22 2023, 4:23 PM

hi @markj, thanks for review.
feel free to commit if you are happy with this.

Closed by commit rGe74dd9577fb0: hwpstate_amd: calculate power if P-state info comes from MSR (authored by jo_bruelltuete.com, committed by markj). · Explain WhyJun 12 2023, 4:52 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGe74dd9577fb0: hwpstate_amd: calculate power if P-state info comes from MSR.

markj added a commit: rGb44b64eeff1d: hwpstate_amd: calculate power if P-state info comes from MSR.Jun 26 2023, 7:53 PM

Revision Contents
Changeset List

Path

Size

sys/

x86/

cpufreq/

hwpstate_amd.c

32 lines

Diff 122061

View Options

sys/x86/cpufreq/hwpstate_amd.c

cpufreq(4): calculate power if P-state info comes from MSRClosedPublicActions