Page MenuHomeFreeBSD
Differential D40111

release/tools/vminage.subr: switch zfs dataset from /usr/home to /home
ClosedPublic
Actions

Authored by • karels on May 15 2023, 4:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sep 27 2024, 12:31 PM
Unknown Object (File)
Sep 24 2024, 3:52 AM
Unknown Object (File)
Sep 23 2024, 8:29 PM
Unknown Object (File)
Sep 17 2024, 9:21 PM
Unknown Object (File)
Sep 5 2024, 1:22 AM
Unknown Object (File)
Aug 30 2024, 5:23 PM
Unknown Object (File)
Aug 30 2024, 3:38 PM
Unknown Object (File)
Aug 29 2024, 9:27 AM
View All 47 Files
Subscribers
imp
jrtc27

Details

Reviewers
markj
Summary

Change the vmimage script for zfs to create /home as a dataset
rather than /usr/home, ala pending change to bsdinstall.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 51503
Build 48394: arc lint + arc unit

Event Timeline

• karels created this revision.May 15 2023, 4:07 PM
Herald added subscribers: jrtc27, imp. · View Herald TranscriptMay 15 2023, 4:07 PM
• karels requested review of this revision.May 15 2023, 4:07 PM
Harbormaster completed remote builds in B51502: Diff 121985.May 15 2023, 4:07 PM
markj added inline comments.May 15 2023, 4:14 PM
release/tools/vmimage.subr
196
• karels updated this revision to Diff 121986.May 15 2023, 4:19 PM

Add missing backslash

Harbormaster completed remote builds in B51503: Diff 121986.May 15 2023, 4:19 PM
• karels marked an inline comment as done.May 15 2023, 4:20 PM
• karels added inline comments.
release/tools/vmimage.subr
196

Oops, thanks!

• karels marked an inline comment as done.May 15 2023, 5:57 PM

This change seems to work; /home is mounted from zroot/home, and /usr/home does not exist. /home has no contents, but that is presumably expected.

I noted that the raw image is about 21 GiB, a bit larger than the requested size of 20G.

markj accepted this revision.May 15 2023, 6:08 PM
In D40111#913442, @karels wrote:

This change seems to work; /home is mounted from zroot/home, and /usr/home does not exist. /home has no contents, but that is presumably expected.

Yes, a fresh image wouldn't have any users with a home directory installed, and root's is /root.

I noted that the raw image is about 21 GiB, a bit larger than the requested size of 20G.

Might be that the size specifies the root filesystem size, whereas the image includes bootcode and an ESP.

This revision is now accepted and ready to land.May 15 2023, 6:08 PM
• karels added a comment.May 15 2023, 7:52 PM
In D40111#913448, @markj wrote:
In D40111#913442, @karels wrote:

I noted that the raw image is about 21 GiB, a bit larger than the requested size of 20G.

Might be that the size specifies the root filesystem size, whereas the image includes bootcode and an ESP.

Yes, I checked the partitions; zfs is 20 GB, then there is 1 GB swap, plus misc.

• karels mentioned this in rGd3c32c80a16b: release/tools/vmimage.subr: switch zfs dataset from /usr/home to /home.May 23 2023, 12:24 PM
• karels added a comment.May 23 2023, 12:31 PM

Closed by commit rGd3c32c80a16b: release/tools/vmimage.subr: switch zfs dataset from /usr/home to /home (authored by karels).

• karels closed this revision.May 23 2023, 12:32 PM

Revision Contents
Changeset List

PathSize
release/
tools/
2 lines

Diff 121986

View Options

release/tools/vmimage.subr

Loading...