kdump: Add a facility to print numbers always in decimal format
ClosedPublic
Actions

Authored by dchagin on May 14 2023, 11:17 PM.

Details

Reviewers

Commits

rG8bfdf839270b: kdump: Add a facility to print numbers in decimal format always
rGc2c9ac88c2bb: kdump: Add a facility to print numbers in decimal format always

Summary

To help grepping kdump output by pid or tid it makes sence to print
some numbers in decimal format always. Eg, process or thread identifier
atleast, as they already printed in decimal format.
Switch to print pid/tid/ arguments of some Linux signal related syscalls
in decimal format.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dchagin created this revision.May 14 2023, 11:17 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 14 2023, 11:17 PM

dchagin requested review of this revision.May 14 2023, 11:17 PM

Harbormaster completed remote builds in B51495: Diff 121949.May 14 2023, 11:18 PM

dchagin retitled this revision from linux(4): Add a facility to print numbers always in decimal format to kdump: Add a facility to print numbers always in decimal format.May 14 2023, 11:21 PM

dchagin added a reviewer: jhb.

I wouldn't mind spelling out "decimal". File descriptor arguments are also good candidates for always printing as decimal BTW.

jhb accepted this revision.May 20 2023, 5:37 PM

This revision is now accepted and ready to land.May 20 2023, 5:37 PM

In D40099#914847, @jhb wrote:

I wouldn't mind spelling out "decimal".

ok, thanks. are you ok if I change native syscalls (signals related, for start) too?
by separate chang of course

File descriptor arguments are also good candidates for always printing as decimal BTW.

Yeah, next time )

Closed by commit rGc2c9ac88c2bb: kdump: Add a facility to print numbers in decimal format always (authored by dchagin). · Explain WhyMay 26 2023, 4:36 PM

This revision was automatically updated to reflect the committed changes.

dchagin added a commit: rGc2c9ac88c2bb: kdump: Add a facility to print numbers in decimal format always.

In D40099#917174, @dchagin wrote:

In D40099#914847, @jhb wrote:

I wouldn't mind spelling out "decimal".

ok, thanks. are you ok if I change native syscalls (signals related, for start) too?
by separate chang of course