LinuxKPI: fix WRITE_ONCE()
ClosedPublic
Actions

Authored by bz on May 13 2023, 3:37 PM.

Details

Reviewers

jhb
brooks
• hselasky

Group Reviewers

linuxkpi

Commits

rG584bd868b4e4: LinuxKPI: fix WRITE_ONCE()
rG046d8d89ed19: LinuxKPI: fix WRITE_ONCE(), remove ACCESS_ONCE()

Summary

Fix a gcc warning: to be safe all intermediate pointers in cast from
'...' to '...' must be 'const' qualified [-Wcast-qual].
Doing what is essentially a __DECONST() adding the uintptr_t gets
rid of the massive amount of warnings we get in LinuxKPI and lets
us see the actual problems a lot better.
This is a follow-up to 74e908b3c63b28de1d590dc42502fbe959a6da2e which
fixed READ_ONCE().

Suggested by: jhb
MFC after: 10 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 51479
Build 48370: arc lint + arc unit

Event Timeline

bz created this revision.May 13 2023, 3:37 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptMay 13 2023, 3:37 PM

bz requested review of this revision.May 13 2023, 3:37 PM

Harbormaster completed remote builds in B51479: Diff 121928.May 13 2023, 3:37 PM

• hselasky added a reviewer: brooks.May 13 2023, 6:53 PM

• hselasky added a subscriber: • hselasky.

• hselasky added inline comments.

sys/compat/linuxkpi/common/include/linux/compiler.h
91	Hi, ACCESS_ONCE() used to be a valid Linux API: Documentation/RCU/RTFP.txt: ACCESS_ONCE(). But I think it is obsolete. Maybe say something about that in the commit message! --HPS
93	This also works for CheriBSD and capability pointers?