Page MenuHomeFreeBSD

sshd: remove unneeded initialization of libwrap logging severities
ClosedPublic

Authored by glebius on May 11 2023, 7:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 7:36 PM
Unknown Object (File)
Thu, Nov 7, 12:12 PM
Unknown Object (File)
Wed, Nov 6, 1:39 PM
Unknown Object (File)
Oct 8 2024, 12:07 PM
Unknown Object (File)
Oct 8 2024, 12:06 PM
Unknown Object (File)
Oct 8 2024, 12:06 PM
Unknown Object (File)
Oct 8 2024, 11:37 AM
Unknown Object (File)
Oct 2 2024, 5:37 AM
Subscribers

Details

Summary

This part of ca573c9a177 proved to be unnecessary. As the removed
comment says, we set them merely for logging syntax errors, as we log
refusals ourselves. However, inside the libwrap the parser logs any
syntax errors with tcpd_warn() which has hardcoded LOG_WARNING inside.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 51452
Build 48343: arc lint + arc unit

Event Timeline

philip added a subscriber: philip.

If neither allow_severity or deny_severity are referenced anywhere else, this looks good to me.
I have only reviewed the patch. I haven't actually tested it.

crypto/openssh/sshd.c
145

Is allow_severity not referenced anywhere else?

This revision is now accepted and ready to land.May 16 2023, 6:06 AM