e1000: fix VLAN 0
ClosedPublic
Actions

Authored by kp on May 10 2023, 4:34 PM.

Details

Reviewers

Group Reviewers

pfsense
network
Restricted Owners Package	(Owns No Changed Paths)

Commits

rGeaa16e7edba1: e1000: fix VLAN 0
rG5cb5b368829d: e1000: fix VLAN 0
rG0229fab2fe0e: e1000: fix VLAN 0

Summary

On igb/em interfaces we did not receive packets with VLAN tag 0 unless
vlanhwfilter was disabled.

This can be fixed by explicitly listing VLAN 0 in the hardware VLAN
filter (VFTA). Do this from em_setup_vlan_hw_support(), where we already
(re-)write the VFTA.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 51423
Build 48314: arc lint + arc unit

Event Timeline

kp created this revision.May 10 2023, 4:34 PM

Owners added a reviewer: Restricted Owners Package.May 10 2023, 4:34 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 10 2023, 4:34 PM

kp requested review of this revision.May 10 2023, 4:34 PM

Harbormaster completed remote builds in B51423: Diff 121812.May 10 2023, 4:34 PM

kp added a reviewer: kbowling.May 10 2023, 8:23 PM

I think it's probably fine but can you elaborate situations where vlan 0 is "tagged"

VLAN 0 Priority Tagging feature enables 802.1Q Ethernet frames to be transmitted with the VLAN ID set to zero.

Some people need VLAN 0 because their ISP wants to see it (PPPoE links, some AT&T U-Verse see: https://github.com/MonkWho/pfatt)

See also: 802.1Q-2005 page 76 Section 9.6, Table 9-2.

VID value (hexadecimal)
Meaning/Use
0
The null VLAN ID. Indicates that the tag header contains only priority information; no VLAN identifier is present in the frame. This VID value shall not be configured as a PVID or a member of a VID Set, or configured in any Filtering Database entry, or used in any Management operation.

1
The default PVID value used for classifying frames on ingress through a Bridge Port. The PVID value of a Port can be changed by management.

FFF
Reserved for implementation use. This VID value shall not be configured as a PVID or a member of a VID Set, or transmitted in a tag header. This VID value may be used to indicate a wildcard match for the VID in management operations or Filtering Database entries.