Page MenuHomeFreeBSD

riscv: rework CPU identification [7/7]
ClosedPublic

Authored by mhorne on May 9 2023, 5:16 PM.
Tags
None
Referenced Files
F98259298: D40024.diff
Wed, Oct 2, 8:33 PM
Unknown Object (File)
Sat, Sep 21, 8:31 PM
Unknown Object (File)
Thu, Sep 19, 2:04 AM
Unknown Object (File)
Tue, Sep 17, 7:30 PM
Unknown Object (File)
Tue, Sep 17, 11:56 AM
Unknown Object (File)
Mon, Sep 16, 4:00 PM
Unknown Object (File)
Mon, Sep 16, 7:51 AM
Unknown Object (File)
Sun, Sep 8, 8:06 AM
Subscribers

Details

Summary

Change the reporting strategy to more closely follow what arm64
implements:

  • Always print the one-line CPU summary when a core comes online
  • Only print the additional fields (e.g. ISA) when they differ from the CPU before it

In the common case of identical CPUs this results in informative but
non-repetitive output.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mhorne requested review of this revision.May 9 2023, 5:16 PM
markj added inline comments.
sys/riscv/riscv/identcpu.c
459

Indentation looks wrong here.

This revision is now accepted and ready to land.May 11 2023, 3:35 PM
This revision was automatically updated to reflect the committed changes.
mhorne marked an inline comment as done.