loader: install help files only once

[emaste]

Summary

PR: 271178

[emaste]

Happy to defer to an alternative approach if someone wants to come up with a cleaner way.

[mhorne]

This is simple, and makes sense to me. I think you should be consistent about which interpreter variant is the "yes" one; for efi and userboot it is "simp" but for i386 it is "4th".

If I understand things correctly, we only build one variant for kboot, ubldr, and ofw loader, so they should be unaffected.

[emaste]

In D40021#911316, @mhorne wrote:

This is simple, and makes sense to me. I think you should be consistent about which interpreter variant is the "yes" one; for efi and userboot it is "simp" but for i386 it is "4th".

Oh yes, it should be simp for i386 as well. The "yes" one should be the one that is always installed e.g. SUBDIR.yes+= loader_simp

If I understand things correctly, we only build one variant for kboot, ubldr, and ofw loader, so they should be unaffected.

Correct.

[emaste]

install i386 help files via loader_simp

[imp]

Id prefer we do all of them in simp.
I'm not sure I like this. It's kinda fugly. But i have no better idea off the top of my head, but I'll mull this over...

[emaste]

I'm not sure I like this. It's kinda fugly.

I don't disagree - as I said I'm happy to defer to something nicer.

[emaste]

With this change applied if_wg.h (PR271266) is the only file appearing twice.

[emaste]

if_wg.h fix in D40031