Page MenuHomeFreeBSD
Differential D40018

md5: Include <osreldate.h> for __FreeBSD_version.
ClosedPublic
Actions

Authored by des on May 9 2023, 10:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 16, 5:24 AM
Unknown Object (File)
Sun, Sep 15, 5:27 PM
Unknown Object (File)
Tue, Sep 10, 9:31 AM
Unknown Object (File)
Fri, Sep 6, 10:47 AM
Unknown Object (File)
Aug 8 2024, 9:57 PM
Unknown Object (File)
Aug 8 2024, 9:46 PM
Unknown Object (File)
Jun 5 2024, 8:04 PM
Unknown Object (File)
Jun 4 2024, 2:17 PM
View All 42 Files
Subscribers
imp

Details

Reviewers
yuripv
kevans
Group Reviewers
Klara
Commits
rG90eaf4b2f98f: md5: Include <osreldate.h> for __FreeBSD_version.
Summary

It is usually provided by <sys/param.h>, but not when bootstrapping.

Fixes: 4849767cb16a
MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 51397
Build 48288: arc lint + arc unit

Event Timeline

des created this revision.May 9 2023, 10:00 AM
Herald added a subscriber: imp. · View Herald TranscriptMay 9 2023, 10:00 AM
des requested review of this revision.May 9 2023, 10:00 AM
des added a parent revision: D40017: md5: Fix input error check..May 9 2023, 10:00 AM
Harbormaster completed remote builds in B51391: Diff 121731.May 9 2023, 10:00 AM
des mentioned this in D40015: md5: attempt fixing cross-builds in github ci.May 9 2023, 10:08 AM
des added a child revision: D40020: md5: Don't increment a bool..May 9 2023, 11:28 AM
yuripv added inline comments.May 9 2023, 12:02 PM
sbin/md5/md5.c
23

I wanted to propose the same, but looking at the history looks like param.h was added for the same reason of bootstrapping:

commit cab31e0e216c7defefd4aba14693ba2252ea7308
Author: Jessica Clarke <jrtc27@FreeBSD.org>
Date:   Fri Jun 25 22:00:11 2021 +0100

    md5: Fix cross-build after c2870e576bd2

    On macOS and Linux the current set of headers do not end up pulling in
    sys/param.h, causing MAXPATHLEN to not be defined and the build to fail.
des retitled this revision from md5: Use <osreldate.h> instead of <sys/param.h> to md5: Include <osreldate.h> for __FreeBSD_version..May 9 2023, 4:40 PM
des edited the summary of this revision. (Show Details)
des updated this revision to Diff 121755.May 9 2023, 4:40 PM

We still need <sys/param.h>.

des marked an inline comment as done.May 9 2023, 4:40 PM
Harbormaster completed remote builds in B51397: Diff 121755.May 9 2023, 4:41 PM
yuripv accepted this revision.May 9 2023, 4:41 PM
This revision is now accepted and ready to land.May 9 2023, 4:41 PM
kevans accepted this revision.May 9 2023, 5:36 PM
Closed by commit rG90eaf4b2f98f: md5: Include <osreldate.h> for __FreeBSD_version. (authored by des). · Explain WhyMay 10 2023, 9:27 AM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG90eaf4b2f98f: md5: Include <osreldate.h> for __FreeBSD_version..

Revision Contents
Changeset List

PathSize
sbin/
md5/
1 line

Diff 121755

View Options

sbin/md5/md5.c

Loading...